Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2310113002: provide safe exit for runaway intersections (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

provide safe exit for runaway intersections Curve intersections with extreme numbers may cause the intersection template code to loop forever. Detect this by looking for marking more spans gone than exist, and return without any intersections found. TBR=reed@google.com BUG=643855 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2310113002 Committed: https://skia.googlesource.com/skia/+/ef7cee4bbc7c4c1c21b00834de7119634a3c35c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -24 lines) Patch
M src/pathops/SkPathOpsTSect.h View 13 chunks +42 lines, -24 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310113002/1
4 years, 3 months ago (2016-09-06 15:39:38 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:05:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ef7cee4bbc7c4c1c21b00834de7119634a3c35c9

Powered by Google App Engine
This is Rietveld 408576698