Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2310093003:
Make BindStateBase constructor out-of-line (Closed)
|
Created:
4 years, 3 months ago by tzik Modified:
4 years, 3 months ago Reviewers:
Yuta Kitamura CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake BindStateBase constructor out-of-line
The out-of-line constructor generates smaller binary after
http://crrev.com/2317563002, and the binary size growth along with
the member addition to BindStateBase is slower on the out-of-line
constructor.
This CL reduces the stripped binary size of chrome by 36kB on Linux.
Committed: https://crrev.com/f1b377726b3483dc0dfc63d38737b267ceaddadf
Cr-Commit-Position: refs/heads/master@{#417212}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 27 (22 generated)
Description was changed from ========== Make BindStateBase constructor out-of-line ========== to ========== Make BindStateBase constructor out-of-line The out-of-line constructor generates smaller binary after http://crrev.com/2317563002, and the binary size growth along with the member addition to BindStateBase is slower on the out-of-line constructor. This CL reduces the stripped binary size of chrome by 36kB on Linux. ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
tzik@chromium.org changed reviewers: + yutak@chromium.org
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org Link to the patchset: https://codereview.chromium.org/2310093003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make BindStateBase constructor out-of-line The out-of-line constructor generates smaller binary after http://crrev.com/2317563002, and the binary size growth along with the member addition to BindStateBase is slower on the out-of-line constructor. This CL reduces the stripped binary size of chrome by 36kB on Linux. ========== to ========== Make BindStateBase constructor out-of-line The out-of-line constructor generates smaller binary after http://crrev.com/2317563002, and the binary size growth along with the member addition to BindStateBase is slower on the out-of-line constructor. This CL reduces the stripped binary size of chrome by 36kB on Linux. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make BindStateBase constructor out-of-line The out-of-line constructor generates smaller binary after http://crrev.com/2317563002, and the binary size growth along with the member addition to BindStateBase is slower on the out-of-line constructor. This CL reduces the stripped binary size of chrome by 36kB on Linux. ========== to ========== Make BindStateBase constructor out-of-line The out-of-line constructor generates smaller binary after http://crrev.com/2317563002, and the binary size growth along with the member addition to BindStateBase is slower on the out-of-line constructor. This CL reduces the stripped binary size of chrome by 36kB on Linux. Committed: https://crrev.com/f1b377726b3483dc0dfc63d38737b267ceaddadf Cr-Commit-Position: refs/heads/master@{#417212} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f1b377726b3483dc0dfc63d38737b267ceaddadf Cr-Commit-Position: refs/heads/master@{#417212} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
