Chromium Code Reviews| Index: runtime/observatory/lib/src/app/view_model.dart |
| diff --git a/runtime/observatory/lib/src/app/view_model.dart b/runtime/observatory/lib/src/app/view_model.dart |
| index 94edb496bac325876f8b946aac51a476a80b54c7..494e31bed9748eb8f4a5a5b861d314e829db1052 100644 |
| --- a/runtime/observatory/lib/src/app/view_model.dart |
| +++ b/runtime/observatory/lib/src/app/view_model.dart |
| @@ -4,7 +4,7 @@ |
| part of app; |
| -abstract class TableTreeRow extends Observable { |
| +abstract class TableTreeRow { |
| static const arrowRight = '\u2192'; |
| static const arrowDownRight = '\u21b3'; |
| // Number of ems each subtree is indented. |
| @@ -167,7 +167,7 @@ abstract class TableTreeRow extends Observable { |
| } |
| } |
| -class TableTree extends Observable { |
| +class TableTree { |
|
Cutch
2016/09/07 17:09:17
is this being used anymore?
cbernaschina
2016/09/07 17:27:53
No.
Removed TableTree and TableTreeRow
Done
|
| final TableSectionElement tableBody; |
| final List<TableTreeRow> rows = []; |
| final int columnCount; |
| @@ -288,7 +288,7 @@ class SortedTableRow { |
| SortedTableRow(this.values); |
| } |
| -class SortedTable extends Observable { |
| +class SortedTable { |
|
Cutch
2016/09/07 17:09:17
can this code just be deleted now?
cbernaschina
2016/09/07 17:27:53
It is still used by code-view
|
| final List<SortedTableColumn> columns; |
| final List<SortedTableRow> rows = new List<SortedTableRow>(); |
| final List<int> sortedRows = []; |
| @@ -300,14 +300,12 @@ class SortedTable extends Observable { |
| assert(index >= 0); |
| assert(index < columns.length); |
| _sortColumnIndex = index; |
| - notifyPropertyChange(#getColumnLabel, 0, 1); |
| } |
| int get sortColumnIndex => _sortColumnIndex; |
| bool _sortDescending = true; |
| bool get sortDescending => _sortDescending; |
| set sortDescending(var descending) { |
| _sortDescending = descending; |
| - notifyPropertyChange(#getColumnLabel, 0, 1); |
| } |
| @@ -353,7 +351,7 @@ class SortedTable extends Observable { |
| return formatter(value); |
| } |
| - @observable String getColumnLabel(int column) { |
| + String getColumnLabel(int column) { |
| assert(column >= 0); |
| assert(column < columns.length); |
| // TODO(johnmccutchan): Move expander display decisions into html once |