Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2619)

Unified Diff: content/renderer/render_widget.h

Issue 2309983002: Allow selection change update before beginBatchEdit (Closed)
Patch Set: fixed a test failure Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index dc1d2c08a80627e6dd32e1b457b95b55c1066962..19301e69d89cd8f71fc219bc9e4897670a371dbf 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -525,6 +525,10 @@ class CONTENT_EXPORT RenderWidget
// Called by the browser process to update text input state.
void OnRequestTextInputStateUpdate();
+
+ // Called by the browser process to begin (when |begin| is set) or end batch
+ // edit mode. Note that text input state will not be updated in this mode.
+ void OnImeBatchEdit(bool begin);
#endif
// Called by the browser process to update the cursor and composition
@@ -691,6 +695,10 @@ class CONTENT_EXPORT RenderWidget
// ImeEventGuard. We keep track of the outermost one, and update it as needed.
ImeEventGuard* ime_event_guard_;
+ // Whether IME is in batch edit mode, in which case we do not update text
+ // input state.
+ bool ime_in_batch_edit_;
+
// True if we have requested this widget be closed. No more messages will
// be sent, except for a Close.
bool closing_;

Powered by Google App Engine
This is Rietveld 408576698