content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java - Issue 2309983002: Allow selection change update before beginBatchEdit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java

Issue 2309983002: Allow selection change update before beginBatchEdit (Closed)

Patch Set: fixed a test failure Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionFactoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java

diff --git a/content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java b/content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java

index 89787b7e334578bdbaf27c86ea61c477ff2bbbe5..7efd80024015d190091e396c65043caa3e13bcf4 100644

--- a/content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java

+++ b/content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java

@@ -20,7 +20,7 @@ public class TextInputStateTest {

@Feature({"TextInput"})

public void testEmptySelection() {

TextInputState state =

- new TextInputState("hello", new Range(3, 3), new Range(-1, -1), false, true);

+ new TextInputState("hello", new Range(3, 3), new Range(-1, -1), false, true, false);

assertEquals("lo", state.getTextAfterSelection(3));

assertEquals("lo", state.getTextAfterSelection(2));

assertEquals("", state.getTextAfterSelection(0));

@@ -34,7 +34,7 @@ public class TextInputStateTest {

@Feature({"TextInput"})

public void testNonEmptySelection() {

TextInputState state =

- new TextInputState("hello", new Range(3, 4), new Range(3, 4), false, true);

+ new TextInputState("hello", new Range(3, 4), new Range(3, 4), false, true, false);

assertEquals("hel", state.getTextBeforeSelection(4));

assertEquals("hel", state.getTextBeforeSelection(3));

assertEquals("", state.getTextBeforeSelection(0));