content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java - Issue 2309983002: Allow selection change update before beginBatchEdit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

Issue 2309983002: Allow selection change update before beginBatchEdit (Closed)

Patch Set: fixed a test failure Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

index 89b8f61a14101ea54aff469eae7af8a3755d1d78..1c91bbbd42cf34fefa1fd342927fe3682d402681 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java

@@ -115,7 +115,8 @@ public class ReplicaInputConnection

@Override

public void updateStateOnUiThread(String text, int selectionStart, int selectionEnd,

- int compositionStart, int compositionEnd, boolean singleLine, boolean isNonImeChange) {

+ int compositionStart, int compositionEnd, boolean singleLine, boolean isNonImeChange,

+ boolean inBatchEditMode) {

if (DEBUG_LOGS) {

Log.w(TAG, "updateState [%s] [%s %s] [%s %s] [%b] [%b]", text, selectionStart,

selectionEnd, compositionStart, compositionEnd, singleLine, isNonImeChange);