test/unittests/compiler/js-typed-lowering-unittest.cc - Issue 2309953002: [turbofan] Introduce dedicated NumberToBoolean operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 2309953002: [turbofan] Introduce dedicated NumberToBoolean operator. (Closed)

Patch Set: Fix unittest. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/js-typed-lowering-unittest.cc

diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc

index c3879a5cf97947f2b225c96795a182fd1ff12647..765f18fbc3f994d093421b3e6d6441c60cc47fe9 100644

--- a/test/unittests/compiler/js-typed-lowering-unittest.cc

+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc

@@ -113,8 +113,7 @@ TEST_F(JSTypedLoweringTest, JSToBooleanWithNumber) {

Reduction r = Reduce(graph()->NewNode(

javascript()->ToBoolean(ToBooleanHint::kAny), input, context));

ASSERT_TRUE(r.Changed());

- EXPECT_THAT(r.replacement(),

- IsNumberLessThan(IsNumberConstant(0.0), IsNumberAbs(input)));

+ EXPECT_THAT(r.replacement(), IsNumberToBoolean(input));

}

TEST_F(JSTypedLoweringTest, JSToBooleanWithString) {

« no previous file with comments | « src/compiler/verifier.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »