Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2309943005:
[Tracing] Minor bug fixes related to trace serialization (Closed)
Description[Tracing] Minor bug fixes related to trace serialization
Escape sequences may now be written to a trace file (previously,
any string with a valid escapable character would fail a check).
Also, string properties are now surrounded with quotes.
BUG=v8:4561
Committed: https://crrev.com/ec9bfc853b9df1531a01dfdd53daad5a12a243ff
Cr-Commit-Position: refs/heads/master@{#39319}
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== [Tracing] Minor bug fixes related to trace serialization Escape sequences may now be written to a trace file (previously, any string with a valid escapable character would fail a check). Also, string properties are now surrounded with quotes. BUG=v8:4561 ========== to ========== [Tracing] Minor bug fixes related to trace serialization Escape sequences may now be written to a trace file (previously, any string with a valid escapable character would fail a check). Also, string properties are now surrounded with quotes. BUG=v8:4561 ==========
kelvinjin@google.com changed reviewers: + fmeawad@google.com, lpy@google.com, mattloring@google.com
On 2016/09/06 17:44:21, kelvinjin wrote: > mailto:kelvinjin@google.com changed reviewers: > + mailto:fmeawad@google.com, mailto:lpy@google.com, mailto:mattloring@google.com The changes to serialization are the same as in https://codereview.chromium.org/2307163002/ but this CL doesn't introduce any API changes.
lpy@chromium.org changed reviewers: + lpy@chromium.org - lpy@google.com
LGTM from my side.
fmeawad@chromium.org changed reviewers: + fmeawad@chromium.org
lgtm
lpy@chromium.org changed reviewers: + yangguo@chromium.org - fmeawad@google.com
+ Yang@, could you take a look at this CL?
lpy@chromium.org changed reviewers: + jochen@chromium.org - yangguo@chromium.org
looks like Yang@ is OOO, jochen@ could you please take a look?
lgtm
The CQ bit was checked by kelvinjin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kelvinjin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Minor bug fixes related to trace serialization Escape sequences may now be written to a trace file (previously, any string with a valid escapable character would fail a check). Also, string properties are now surrounded with quotes. BUG=v8:4561 ========== to ========== [Tracing] Minor bug fixes related to trace serialization Escape sequences may now be written to a trace file (previously, any string with a valid escapable character would fail a check). Also, string properties are now surrounded with quotes. BUG=v8:4561 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Minor bug fixes related to trace serialization Escape sequences may now be written to a trace file (previously, any string with a valid escapable character would fail a check). Also, string properties are now surrounded with quotes. BUG=v8:4561 ========== to ========== [Tracing] Minor bug fixes related to trace serialization Escape sequences may now be written to a trace file (previously, any string with a valid escapable character would fail a check). Also, string properties are now surrounded with quotes. BUG=v8:4561 Committed: https://crrev.com/ec9bfc853b9df1531a01dfdd53daad5a12a243ff Cr-Commit-Position: refs/heads/master@{#39319} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ec9bfc853b9df1531a01dfdd53daad5a12a243ff Cr-Commit-Position: refs/heads/master@{#39319} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
