third_party/WebKit/Source/modules/budget/BudgetService.h - Issue 2309863002: Plumb reserve method of the BudgetAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/budget/BudgetService.h

Issue 2309863002: Plumb reserve method of the BudgetAPI (Closed)

Patch Set: Rename BudgetServiceErrorType::NO_ERROR to ::NONE to avoid Windows constant name clash. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/Source/modules/budget/BudgetService.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/budget/BudgetService.h

diff --git a/third_party/WebKit/Source/modules/budget/BudgetService.h b/third_party/WebKit/Source/modules/budget/BudgetService.h

index 73c0313040c74549a0049b50e20cd3a3767ea833..ae84593fe2e76bdad998da204fc1aea990add434 100644

--- a/third_party/WebKit/Source/modules/budget/BudgetService.h

+++ b/third_party/WebKit/Source/modules/budget/BudgetService.h

@@ -30,15 +30,17 @@ public:

~BudgetService();

// Implementation of the Budget API interface.

- ScriptPromise getCost(ScriptState*, const AtomicString& actionType);

+ ScriptPromise getCost(ScriptState*, const AtomicString& operation);

ScriptPromise getBudget(ScriptState*);

+ ScriptPromise reserve(ScriptState*, const AtomicString& operation);

DEFINE_INLINE_TRACE() {}

private:

// Callbacks from the BudgetService to the blink layer.

void gotCost(ScriptPromiseResolver*, double cost) const;

- void gotBudget(ScriptPromiseResolver*, const mojo::WTFArray<mojom::blink::BudgetStatePtr> expectations) const;

+ void gotBudget(ScriptPromiseResolver*, mojom::blink::BudgetServiceErrorType, const mojo::WTFArray<mojom::blink::BudgetStatePtr> expectations) const;

+ void gotReservation(ScriptPromiseResolver*, mojom::blink::BudgetServiceErrorType, bool success) const;

// Error handler for use if mojo service doesn't connect.

void onConnectionError();