third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html - Issue 2309863002: Plumb reserve method of the BudgetAPI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html

Issue 2309863002: Plumb reserve method of the BudgetAPI (Closed)

Patch Set: Updated with code review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js ('K') | « third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html ('k') | third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js » ('j') | third_party/WebKit/public/platform/modules/budget_service/budget_service.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Budget API: Verifies that the right Budget API interfaces get exposed .</title>	4 <title>Budget API: Verifies that the right Budget API interfaces get exposed .</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 </head>	7 </head>

8 <body>	8 <body>

9 <script>	9 <script>

10 promise_test(function() {	10 promise_test(function() {

11 assert_own_property(Navigator.prototype, 'budget');	11 assert_own_property(Navigator.prototype, 'budget');

12 assert_own_property(BudgetService.prototype, 'getCost');	12 assert_own_property(BudgetService.prototype, 'getCost');

13 assert_own_property(BudgetService.prototype, 'getBudget');	13 assert_own_property(BudgetService.prototype, 'getBudget');

	14 assert_own_property(BudgetService.prototype, 'reserve');

14 assert_equals(navigator.budget, navigator.budget);	15 assert_equals(navigator.budget, navigator.budget);

15	16

16 navigator.budget.getCost()	17 navigator.budget.getCost()

17 .then(function(cost) {	18 .then(function(cost) {

18 assert_unreached('getCost should have failed.');	19 assert_unreached('getCost should have failed.');

19 }, function(error) {	20 }, function(error) {

20 assert_equals(error.name, 'NotSupportedError');	21 assert_equals(error.name, 'NotSupportedError');

21 assert_equals(error.message, 'Not yet implemented');	22 assert_equals(error.message, 'Not yet implemented');

22 });	23 });

23 navigator.budget.getBudget()	24 navigator.budget.getBudget()

24 .then(function(cost) {	25 .then(function(cost) {

25 assert_unreached('getBudget should have failed.');	26 assert_unreached('getBudget should have failed.');

26 }, function(error) {	27 }, function(error) {

27 assert_equals(error.name, 'NotSupportedError');	28 assert_equals(error.name, 'NotSupportedError');

28 assert_equals(error.message, 'Not yet implemented');	29 assert_equals(error.message, 'Not yet implemented');

29 });	30 });

	31 navigator.budget.reserve()

	32 .then(function(cost) {

	33 assert_unreached('reserve should have failed.');

	34 }, function(error) {

	35 assert_equals(error.name, 'NotSupportedError');

	36 assert_equals(error.message, 'Not yet implemented');

	37 });

30 }, 'NavigatorBudget should be exposed and have the expected interface in a Document.');	38 }, 'NavigatorBudget should be exposed and have the expected interface in a Document.');

31 </script>	39 </script>

32 </body>	40 </body>

33 </html>	41 </html>

OLD	NEW