Plumb reserve method of the BudgetAPI

third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js

 /**
  * Mock implementation of the budget service.
  */
 
 "use strict";
 
 const TEST_BUDGET_COST = 1.2;
 const TEST_BUDGET_AT = 2.3;
 const TEST_BUDGET_TIME = new Date().getTime();
 
 let budgetServiceMock = loadMojoModules(
     'budgetServiceMock',
     ['third_party/WebKit/public/platform/modules/budget_service/budget_service.mojom',
      'mojo/public/js/router'
     ]).then(mojo => {
   const [budgetService, router] = mojo.modules;
 
   class BudgetServiceMock {
     constructor(interfaceProvider) {
       interfaceProvider.addInterfaceOverrideForTesting(
           budgetService.BudgetService.name,
           handle => this.connectBudgetService_(handle));
 
       this.interfaceProvider_ = interfaceProvider;
+
+      // Values to return for the next getBudget and getCost calls.
+      this.cost = new Object();

[Peter Beverloo, 2016/09/05 17:06:16]

this.cost_ = {};

(underscore suffix to indicate that it's private; we want a dictionary here, so
easy initialisation will do.)

[harkness, 2016/09/06 15:45:00]

Done.

+      this.budget = new Array();

[Peter Beverloo, 2016/09/05 17:06:16]

this.budget_ = [];

[harkness, 2016/09/06 15:45:00]

Done.

+      this.error = budgetService.BudgetServiceErrorType.NO_ERROR;

[Peter Beverloo, 2016/09/05 17:06:16]

this.error_ = budgetService....

[harkness, 2016/09/06 15:45:00]

Done.

     }
 
     connectBudgetService_(handle) {
       this.budgetServiceStub_ = new budgetService.BudgetService.stubClass(this);
       this.budgetServiceRouter_ = new router.Router(handle);
       this.budgetServiceRouter_.setIncomingReceiver(this.budgetServiceStub_);
     }
 
+    // Set the cost of an operation type for future queries. The operationType
+    // mapping is needed to mirror the mapping that happens in the mojo layer.

[Peter Beverloo, 2016/09/05 17:06:16]

My gut feel is that adding some comments above the methods indicating whether
they (a) implement a Mojo function, or (b) exist for testing purposes would
increase clarity a lot.

[Peter Beverloo, 2016/09/05 17:06:16]

micro nit: mojo -> Mojo

[harkness, 2016/09/06 15:45:00]

I added in a lot of comments, possibly too many. Take a look and let me know
what you think.

[harkness, 2016/09/06 15:45:00]

Done.

+    setCost(operationType, cost) {
+      var mojoOperationType = budgetService.BudgetOperationType.INVALID_OPERATION;

[Peter Beverloo, 2016/09/05 17:06:16]

nit: var -> let

(Try to avoid "var" everywhere. Use "let" when you have to change the value, or
"const" when you don't.)

[harkness, 2016/09/06 15:45:00]

Done.

+      if (operationType == "silent-push")
+        mojoOperationType = budgetService.BudgetOperationType.SILENT_PUSH;
+
+      this.cost[mojoOperationType] = cost;
+    }
+
     getCost(operationType) {
-      return Promise.resolve({ cost:TEST_BUDGET_COST });
+      return Promise.resolve({ cost:this.cost[operationType] });
+    }
+
+    // Add an entry into the budget array to be returned on the next call.
+    addBudget(addTime, addBudget) {
+      this.budget.push({time:addTime, budget_at:addBudget});

[Peter Beverloo, 2016/09/05 17:06:16]

nit: this indentation is inconsistent with the value you create on line 49

[harkness, 2016/09/06 15:45:00]

Done.

+    }
+
+    // Set the error to be returned. This will be acted upon by the
+    // BudgetService in blink.
+    setError(errorName) {
+      switch (errorName) {
+        case "database-error":
+          this.error = budgetService.BudgetServiceErrorType.DATABASE_ERROR;
+          break;
+        case "not-supported":
+          this.error = budgetService.BudgetServiceErrorType.NOT_SUPPORTED;
+          break;
+        case "no-error":
+          this.error = budgetService.BudgetServiceErrorType.NO_ERROR;
+          break;
+      }
     }
 
     getBudget() {
-      return Promise.resolve({ budget: [ { time:TEST_BUDGET_TIME, budget_at:TEST_BUDGET_AT } ] });
+      return Promise.resolve({ errorType:this.error, budget:this.budget });
+    }
+
+    // Set whether the next reserve call should return success or not.
+    setReserveSuccess(success) {
+      this.success = success;
+    }
+
+    reserve() {
+      return Promise.resolve({ errorType:this.error, success:this.success });
     }
   }
   return new BudgetServiceMock(mojo.interfaces);
 });