Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 2309853004: Merge to 53: On the Mac, AX_EVENT_LOAD_COMPLETE should only be fired on the top document. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager_mac.mm
diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm
index 604e42008faa45669f06517fad947ed8f2c832f0..d0052faaa2e6adba6b9727d637973a9aa29d256b 100644
--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm
+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm
@@ -191,7 +191,14 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(
mac_notification = NSAccessibilityLayoutCompleteNotification;
break;
case ui::AX_EVENT_LOAD_COMPLETE:
- mac_notification = NSAccessibilityLoadCompleteNotification;
+ // This notification should only be fired on the top document.
+ // Iframes should use |AX_EVENT_LAYOUT_COMPLETE| to signify that they have
+ // finished loading.
+ if (IsRootTree()) {
+ mac_notification = NSAccessibilityLoadCompleteNotification;
+ } else {
+ mac_notification = NSAccessibilityLayoutCompleteNotification;
+ }
break;
case ui::AX_EVENT_INVALID_STATUS_CHANGED:
mac_notification = NSAccessibilityInvalidStatusChangedNotification;

Powered by Google App Engine
This is Rietveld 408576698