Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2309833003:
[wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. (Closed)
|
Created:
4 years, 3 months ago by bradnelson Modified:
4 years, 3 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline.
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5406
LOG=N
R=mstarzinger@chromium.org,machenbach@chromium.org
Committed: https://crrev.com/7e07d3f66973171ca9c6fc66592caea80af98f2d
Cr-Commit-Position: refs/heads/master@{#39521}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : Disable one #
Total comments: 3
Patch Set 4 : fix #Patch Set 5 : fix #Patch Set 6 : merge #
Messages
Total messages: 45 (33 generated)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bradnelson@google.com changed reviewers: + bradnelson@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
What actually needs to happen to bring this live?
On 2016/09/06 04:21:38, bradn wrote: > What actually needs to happen to bring this live? lgtm Please start a thread discussing about this somewhere. E.g. in a dedicated bug or a group. Bringing this live requires some resource planning. It depends on how many bots you want to have it run and how many tests it needs to cover.
On 2016/09/06 08:21:18, machenbach (slow) wrote: > On 2016/09/06 04:21:38, bradn wrote: > > What actually needs to happen to bring this live? > > lgtm > > Please start a thread discussing about this somewhere. E.g. in a dedicated bug > or a group. Bringing this live requires some resource planning. It depends on > how many bots you want to have it run and how many tests it needs to cover. Never mind, find a comment in a doc. Discussing there.
After more offline discussion, here my suggestion, but I'm not sure it will work
with the current variant logic. A test makes sense to run with asm_wasm variant
if it:
A) has no //flags comment that activates the same runtime flag by default
B) is a test that affects asm-wasm at all
1. This change is fine.
2. Add the variant to the "more" or "extra" set in run-tests.py. It'll run on
all (or most in case of extra) bots.
3. Add a test skipping block to all test suites' status files (minimum test262,
mozilla, cctest, unittests, mjsunit) skipping everything in that variant, e.g.:
['variant == asm_wasm', {
'*': [SKIP],
}], # variant == asm_wasm
4. Only where it makes sense, reenable the folders that matter, e.g.:
['variant == asm_wasm', {
'*': [SKIP],
'asm_wasm/*': [PASS],
'regress/*': [PASS],
}], # variant == asm_wasm
The last one is the part that I'm not sure about. Maybe the first *-skip is
merged to all the others. Maybe only the most specific matches. In case of the
former, we need some more sophisticated logic first, in which case you should
only use the "extra" set and just SKIP as much as possible of the things that
don't make sense.
Please land all this in one CL. E.g. this CL.
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8358) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
Description was changed from ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ========== to ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. Disable one simd.js test failing due to incorrectly supported asm.js module variant (issue v8:5356 filed). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ==========
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Done. PTAL (had to disable one variant that doesn't work, will fix soon)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2309833003/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2309833003/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:842: '*': [SKIP], This doesn't really seem to work :( tools/run-tests.py --outdir=out.gn/x64.release mjsunit --variants=asm_wasm --progress=verbose >>> Running tests for x64.release No connection to distribution server; running tests locally. Running 0 tests
https://codereview.chromium.org/2309833003/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2309833003/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:842: '*': [SKIP], On 2016/09/07 07:03:59, machenbach (slow) wrote: > This doesn't really seem to work :( > > tools/run-tests.py --outdir=out.gn/x64.release mjsunit --variants=asm_wasm > --progress=verbose > >>> Running tests for x64.release > No connection to distribution server; running tests locally. > Running 0 tests The logic doesn't make a difference between more ore less specific wildcards: https://cs.chromium.org/chromium/src/v8/tools/testrunner/local/testsuite.py?l... It just merges all outcomes together. As a work-around we could just blacklist all other directories and the low hanging fruits. Like: 'bugs/*': [SKIP], 'compiler/*': [SKIP], 'es6/*': [SKIP], 'es7/*': [SKIP], 'es8/*': [SKIP], 'harmony/*': [SKIP], 'ignition/*': [SKIP], 'lithium/*': [SKIP], 'third_party/*': [SKIP], 'tools/*': [SKIP], 'apply': [SKIP], 'math-*': [SKIP], 'unicode-test': [SKIP], 'whitespaces': [SKIP],
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. Disable one simd.js test failing due to incorrectly supported asm.js module variant (issue v8:5356 filed). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ========== to ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ========== to ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5406 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ==========
The CQ bit was unchecked by bradnelson@chromium.org
The CQ bit was checked by bradnelson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2309833003/#ps100001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5406 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ========== to ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5406 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5406 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org ========== to ========== [wasm] asm.js: Add asm_wasm variant to test asm.js->wasm pipeline. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5406 LOG=N R=mstarzinger@chromium.org,machenbach@chromium.org Committed: https://crrev.com/7e07d3f66973171ca9c6fc66592caea80af98f2d Cr-Commit-Position: refs/heads/master@{#39521} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/7e07d3f66973171ca9c6fc66592caea80af98f2d Cr-Commit-Position: refs/heads/master@{#39521}
Message was sent while issue was closed.
https://codereview.chromium.org/2309833003/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2309833003/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:842: '*': [SKIP], On 2016/09/07 07:26:42, machenbach (slow) wrote: > On 2016/09/07 07:03:59, machenbach (slow) wrote: > > This doesn't really seem to work :( > > > > tools/run-tests.py --outdir=out.gn/x64.release mjsunit --variants=asm_wasm > > --progress=verbose > > >>> Running tests for x64.release > > No connection to distribution server; running tests locally. > > Running 0 tests > > The logic doesn't make a difference between more ore less specific wildcards: > https://cs.chromium.org/chromium/src/v8/tools/testrunner/local/testsuite.py?l... > > It just merges all outcomes together. As a work-around we could just blacklist > all other directories and the low hanging fruits. Like: > > 'bugs/*': [SKIP], > 'compiler/*': [SKIP], > 'es6/*': [SKIP], > 'es7/*': [SKIP], > 'es8/*': [SKIP], > 'harmony/*': [SKIP], > 'ignition/*': [SKIP], > 'lithium/*': [SKIP], > 'third_party/*': [SKIP], > 'tools/*': [SKIP], > > 'apply': [SKIP], > 'math-*': [SKIP], > 'unicode-test': [SKIP], > 'whitespaces': [SKIP], Done. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
