Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 23098004: Add FINAL and OVERRIDE macros for C++11 final/override. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add FINAL and OVERRIDE macros for C++11 final/override. We also use new the constant naming scheme for Yield::Kind values to avoid clash with the FINAL macro. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16222

Patch Set 1 #

Total comments: 2

Patch Set 2 : Better compiler detection for final/override #

Patch Set 3 : Autoconfied for Sven :-) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -27 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ast.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/globals.h View 1 2 2 chunks +71 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/parser.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Benedikt Meurer
PTAL
7 years, 4 months ago (2013-08-19 07:34:19 UTC) #1
Benedikt Meurer
Danno, here's the FINAL/OVERRIDE CL just mentioned.
7 years, 4 months ago (2013-08-19 08:11:18 UTC) #2
Benedikt Meurer
On 2013/08/19 08:11:18, Benedikt Meurer wrote: > Danno, here's the FINAL/OVERRIDE CL just mentioned. The ...
7 years, 4 months ago (2013-08-19 09:01:41 UTC) #3
Sven Panne
https://codereview.chromium.org/23098004/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/23098004/diff/1/src/globals.h#newcode382 src/globals.h:382: #if __cplusplus >= 201103L Looking at Chrome's base/compiler_specific.h, I ...
7 years, 4 months ago (2013-08-19 12:44:47 UTC) #4
Benedikt Meurer
On 2013/08/19 12:44:47, Sven Panne wrote: > https://codereview.chromium.org/23098004/diff/1/src/globals.h > File src/globals.h (right): > > https://codereview.chromium.org/23098004/diff/1/src/globals.h#newcode382 ...
7 years, 4 months ago (2013-08-19 14:31:06 UTC) #5
Benedikt Meurer
PTAL
7 years, 4 months ago (2013-08-19 14:43:38 UTC) #6
Sven Panne
lgtm
7 years, 4 months ago (2013-08-19 14:45:54 UTC) #7
Benedikt Meurer
7 years, 4 months ago (2013-08-19 14:46:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r16222.

Powered by Google App Engine
This is Rietveld 408576698