Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2309753002: [turbofan] Nuke class types. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Nuke class types. There are no users of class types left inside TurboFan, so we can nuke them and thereby simplify the type system quite a bit. R=mvstanton@chromium.org BUG=v8:5267, v8:5270 Committed: https://crrev.com/7e95e2064ab5387838a05fc20ece9a1e04c93056 Cr-Commit-Position: refs/heads/master@{#39152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -739 lines) Patch
M src/types.h View 10 chunks +2 lines, -68 lines 0 comments Download
M src/types.cc View 10 chunks +0 lines, -95 lines 0 comments Download
M test/cctest/ast-types-fuzz.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-ast-types.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/test-types.cc View 28 chunks +27 lines, -513 lines 0 comments Download
M test/cctest/types-fuzz.h View 9 chunks +7 lines, -57 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-05 08:17:24 UTC) #1
Benedikt Meurer
Hey Michael, Say Bye bye to class types... :-) Please take a look. Thanks, Benedikt
4 years, 3 months ago (2016-09-05 08:18:03 UTC) #4
mvstanton
lgtm
4 years, 3 months ago (2016-09-05 08:30:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309753002/1
4 years, 3 months ago (2016-09-05 09:16:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 09:18:43 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 09:19:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e95e2064ab5387838a05fc20ece9a1e04c93056
Cr-Commit-Position: refs/heads/master@{#39152}

Powered by Google App Engine
This is Rietveld 408576698