[turbofan] Improve graph for JumpIfTrue/False and JumpIfToBooleanTrue/False.

[turbofan] Improve graph for JumpIfTrue/False and JumpIfToBooleanTrue/False.

Avoid the useless strict equality comparisons with true/false being
generated for the JumpIfTrue, JumpIfFalse, JumpIfToBooleanTrue and
JumpIfToBooleanFalse bytecodes. Instead feed the accumulator (or the
outcome of ToBoolean) directly to the Branch node and do the negation
as part of the control flow.

The previous subraphs would render the loop variable analysis useless,
and would cause a lot of unnecessary bit materialization, because many
of our optimizations don't kick in.

Note: This is only part of the problem, there are more subtle differences
in the bytecode pipeline that prevent several important optimizations to
kick in.

R=mstarzinger@chromium.org
BUG=v8:5267, v8:5348
Committed: https://crrev.com/776a5c100873cd59f32565ba8482417c8b749e7a
Cr-Commit-Position: refs/heads/master@{#39151}

[Benedikt Meurer, 2016-09-05 06:34:42]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 06:34:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-05 06:35:43]

Hey Michi,

Here's a simple refactoring for the BytecodeGraphBuilder that reduces the
unnecessary junk in the initial graph and enables a bunch of optimizations to
suddenly work in the bytecode pipeline.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2016-09-05 06:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 06:57:02]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-09-05 08:40:33]

epertoso@chromium.org changed reviewers:
+ epertoso@chromium.org

[epertoso, 2016-09-05 08:40:33]

lgtm

[Benedikt Meurer, 2016-09-05 08:40:53]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-09-05 08:41:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 08:43:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-05 08:43:46]

Description was changed from

==========
[turbofan] Improve graph for JumpIfTrue/False and JumpIfToBooleanTrue/False.

Avoid the useless strict equality comparisons with true/false being
generated for the JumpIfTrue, JumpIfFalse, JumpIfToBooleanTrue and
JumpIfToBooleanFalse bytecodes. Instead feed the accumulator (or the
outcome of ToBoolean) directly to the Branch node and do the negation
as part of the control flow.

The previous subraphs would render the loop variable analysis useless,
and would cause a lot of unnecessary bit materialization, because many
of our optimizations don't kick in.

Note: This is only part of the problem, there are more subtle differences
in the bytecode pipeline that prevent several important optimizations to
kick in.

R=mstarzinger@chromium.org
BUG=v8:5267,v8:5348
==========

to

==========
[turbofan] Improve graph for JumpIfTrue/False and JumpIfToBooleanTrue/False.

Avoid the useless strict equality comparisons with true/false being
generated for the JumpIfTrue, JumpIfFalse, JumpIfToBooleanTrue and
JumpIfToBooleanFalse bytecodes. Instead feed the accumulator (or the
outcome of ToBoolean) directly to the Branch node and do the negation
as part of the control flow.

The previous subraphs would render the loop variable analysis useless,
and would cause a lot of unnecessary bit materialization, because many
of our optimizations don't kick in.

Note: This is only part of the problem, there are more subtle differences
in the bytecode pipeline that prevent several important optimizations to
kick in.

R=mstarzinger@chromium.org
BUG=v8:5267,v8:5348

Committed: https://crrev.com/776a5c100873cd59f32565ba8482417c8b749e7a
Cr-Commit-Position: refs/heads/master@{#39151}
==========

[commit-bot: I haz the power, 2016-09-05 08:43:47]

Patchset 1 (id:??) landed as
https://crrev.com/776a5c100873cd59f32565ba8482417c8b749e7a
Cr-Commit-Position: refs/heads/master@{#39151}

[Michael Starzinger, 2016-09-05 12:42:51]

LGTM.