Add a sizes attribute runtime flag

Add a sizes attribute runtime flag

BUG=357586
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171164

[Yoav Weiss, 2014-04-09 14:38:40]

This CL simply adds a runtime flag for the sizes attribute.

[Peter Beverloo, 2014-04-09 14:45:41]

https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
File Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
Source/platform/RuntimeEnabledFeatures.in:107: SizesAttribute
status=experimental
random drive-by nit: perhaps name this PictureSizesAttribute, to clarify that
it's not about other @sizes attributes (e.g. <link sizes>)?

[Yoav Weiss, 2014-04-09 14:52:37]

On 2014/04/09 14:45:41, Peter Beverloo wrote:
>
https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
> File Source/platform/RuntimeEnabledFeatures.in (right):
> 
>
https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
> Source/platform/RuntimeEnabledFeatures.in:107: SizesAttribute
> status=experimental
> random drive-by nit: perhaps name this PictureSizesAttribute, to clarify that
> it's not about other @sizes attributes (e.g. <link sizes>)?

Since we're already nitting, I intend the flag to cover the implementation of
both the sizes attribute and the (highly related) extended srcset syntax (i.e.
the resource width descriptors). So should it be "PictureSizesAttribute" or
"PictureSizesSrcsetAttribute"? (or something else entirely)

[Peter Beverloo, 2014-04-09 14:54:23]

On 2014/04/09 14:52:37, Yoav Weiss wrote:
> On 2014/04/09 14:45:41, Peter Beverloo wrote:
> >
>
https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
> > File Source/platform/RuntimeEnabledFeatures.in (right):
> > 
> >
>
https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
> > Source/platform/RuntimeEnabledFeatures.in:107: SizesAttribute
> > status=experimental
> > random drive-by nit: perhaps name this PictureSizesAttribute, to clarify
that
> > it's not about other @sizes attributes (e.g. <link sizes>)?
> 
> Since we're already nitting, I intend the flag to cover the implementation of
> both the sizes attribute and the (highly related) extended srcset syntax (i.e.
> the resource width descriptors). So should it be "PictureSizesAttribute" or
> "PictureSizesSrcsetAttribute"? (or something else entirely)

Perhaps just "PictureSizes" in that case?

[Yoav Weiss, 2014-04-09 14:56:25]

On 2014/04/09 14:54:23, Peter Beverloo wrote:
> On 2014/04/09 14:52:37, Yoav Weiss wrote:
> > On 2014/04/09 14:45:41, Peter Beverloo wrote:
> > >
> >
>
https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
> > > File Source/platform/RuntimeEnabledFeatures.in (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/230973002/diff/1/Source/platform/RuntimeEnabl...
> > > Source/platform/RuntimeEnabledFeatures.in:107: SizesAttribute
> > > status=experimental
> > > random drive-by nit: perhaps name this PictureSizesAttribute, to clarify
> that
> > > it's not about other @sizes attributes (e.g. <link sizes>)?
> > 
> > Since we're already nitting, I intend the flag to cover the implementation
of
> > both the sizes attribute and the (highly related) extended srcset syntax
(i.e.
> > the resource width descriptors). So should it be "PictureSizesAttribute" or
> > "PictureSizesSrcsetAttribute"? (or something else entirely)
> 
> Perhaps just "PictureSizes" in that case?

Done! :)

[eseidel, 2014-04-09 17:43:59]

lgtm

[commit-bot: I haz the power, 2014-04-09 17:45:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/230973002/20001

[commit-bot: I haz the power, 2014-04-09 19:00:19]

Change committed as 171164