Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2309723002: Support split chunk input for WebSocketFrameParser fuzzer (Closed)

Created:
4 years, 3 months ago by Adam Rice
Modified:
4 years, 3 months ago
Reviewers:
bengr, yhirano
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support split chunk input for WebSocketFrameParser fuzzer net::WebSocketFrameParser keeps state between calls as a WebSocket frame header can span multiple reads from the underlying socket. Up until now, the fuzzer only simulated one read. By passing the input in multiple chunks, the coverage of the fuzzer is increased. Also increase max_len to 256. As the per-iteration setup cost is quite high for this fuzzer, a larger input length makes the coverage from each iteration higher without significantly harming speed. R=yhirano BUG= Committed: https://crrev.com/105ae61bf801bb9861859b14eadbe6c1cc2f380b Cr-Commit-Position: refs/heads/master@{#417224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_frame_parser_fuzzer.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Adam Rice
4 years, 3 months ago (2016-09-05 06:15:38 UTC) #1
yhirano
lgtm
4 years, 3 months ago (2016-09-06 06:48:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309723002/1
4 years, 3 months ago (2016-09-06 08:19:45 UTC) #4
Adam Rice
+bengr for BUILD.gn
4 years, 3 months ago (2016-09-06 08:21:57 UTC) #7
bengr
lgtm
4 years, 3 months ago (2016-09-08 00:19:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309723002/1
4 years, 3 months ago (2016-09-08 06:55:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 08:00:31 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 08:03:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/105ae61bf801bb9861859b14eadbe6c1cc2f380b
Cr-Commit-Position: refs/heads/master@{#417224}

Powered by Google App Engine
This is Rietveld 408576698