cc: return resources via a ReturnedResource struct rather than TransferableResource

cc/resources/transferable_resource.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_TRANSFERABLE_RESOURCE_H_
 #define CC_RESOURCES_TRANSFERABLE_RESOURCE_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "cc/base/cc_export.h"
 #include "gpu/command_buffer/common/mailbox.h"
 #include "ui/gfx/size.h"
 
 namespace cc {
 
+struct ReturnedResource;
+
 struct CC_EXPORT TransferableResource {
   TransferableResource();
   ~TransferableResource();
 
+  ReturnedResource Return() const;
+
   unsigned id;
   unsigned sync_point;
   uint32 format;
   uint32 filter;
   gfx::Size size;
   gpu::Mailbox mailbox;
 };
 
 typedef std::vector<TransferableResource> TransferableResourceArray;
 
+struct CC_EXPORT ReturnedResource {

[danakj, 2013/08/16 23:33:35]

Can you move this to its own file please?

[piman, 2013/08/17 01:54:31]

Done.

+  ReturnedResource() : id(0), sync_point(0), filter(0), count(0) {}
+  unsigned id;
+  unsigned sync_point;
+  uint32 filter;
+  int count;
+};
+
+typedef std::vector<ReturnedResource> ReturnedResourceArray;
+
+CC_EXPORT void ReturnResources(const TransferableResourceArray& input,

[danakj, 2013/08/16 23:33:35]

I'm kinda meh about a free function like this, as it's hard to tell where the
function comes from when you look at the call sites.

WDYT of making ReturnedResourceArray a subclass of std::vector<RR>, and making
this a (static?) method of the class?

[piman, 2013/08/17 01:54:31]

As discussed, made it a static in TransferableResource

+                               ReturnedResourceArray* output);
+
 }  // namespace cc
 
 #endif  // CC_RESOURCES_TRANSFERABLE_RESOURCE_H_