Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2309683002: [MD Feedback] Add initial styling to feedback dialog. (Closed)

Created:
4 years, 3 months ago by apacible
Modified:
4 years, 2 months ago
Reviewers:
afakhry
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. BUG=640604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328 Cr-Commit-Position: refs/heads/master@{#422472}

Patch Set 1 #

Patch Set 2 : Updated strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -15 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_feedback/feedback_container.html View 1 2 chunks +41 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 29 (21 generated)
apacible
PTAL, thanks! https://screenshot.googleplex.com/pQ7xk5am5XL.png
4 years, 3 months ago (2016-09-16 04:09:08 UTC) #18
afakhry
On 2016/09/16 04:09:08, apacible wrote: > PTAL, thanks! > > https://screenshot.googleplex.com/pQ7xk5am5XL.png Thanks! Looking at the ...
4 years, 3 months ago (2016-09-20 20:08:18 UTC) #19
apacible
> Thanks! Looking at the screenshot, it seems you haven't yet incorporated the > changes ...
4 years, 3 months ago (2016-09-23 03:28:40 UTC) #20
apacible
Updated strings to reflect changes updates from 640604. https://screenshot.googleplex.com/Ua2EgKxNDeB.png
4 years, 2 months ago (2016-10-01 18:38:05 UTC) #23
afakhry
LGTM, thanks!
4 years, 2 months ago (2016-10-03 17:39:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309683002/100001
4 years, 2 months ago (2016-10-03 17:51:23 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 2 months ago (2016-10-03 18:50:08 UTC) #27
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 18:53:42 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328
Cr-Commit-Position: refs/heads/master@{#422472}

Powered by Google App Engine
This is Rietveld 408576698