|
|
Chromium Code Reviews
Description[MD Feedback] Add initial styling to feedback dialog.
Small tweaks to current dialog, including text sizing and positioning.
BUG=640604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328
Cr-Commit-Position: refs/heads/master@{#422472}
Patch Set 1 #Patch Set 2 : Updated strings. #
Messages
Total messages: 29 (21 generated)
Description was changed from ========== styles BUG= ========== to ========== styles BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== styles BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Update style. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD Feedback] Update style. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Add initial styling. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD Feedback] Add initial styling. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Add initial styling. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [MD Feedback] Add initial styling. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Add initial styling to feedback dialog. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD Feedback] Add initial styling to feedback dialog. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Needs Rebase] [MD Feedback] Add initial styling to feedback dialog. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:60001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== [Needs Rebase] [MD Feedback] Add initial styling to feedback dialog. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Add initial styling to feedback dialog. ==========
apacible@chromium.org changed reviewers: + afakhry@chromium.org
Description was changed from ========== [MD Feedback] Add initial styling to feedback dialog. ========== to ========== [MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. ==========
PTAL, thanks! https://screenshot.googleplex.com/pQ7xk5am5XL.png
On 2016/09/16 04:09:08, apacible wrote: > PTAL, thanks! > > https://screenshot.googleplex.com/pQ7xk5am5XL.png Thanks! Looking at the screenshot, it seems you haven't yet incorporated the changes in https://bugs.chromium.org/p/chromium/issues/detail?id=640604, right? We should probably do that here too. By the way, who decides the looks of this UI? Why are we still in this WIP stage till now? It should be quite easy to finish the final UI in a single CL, but it seems we're blocked on UX to finish the mocks?
> Thanks! Looking at the screenshot, it seems you haven't yet incorporated the > changes in https://bugs.chromium.org/p/chromium/issues/detail?id=640604, right? > We should probably do that here too. Right, I'll update that in the next patch. > By the way, who decides the looks of this UI? Why are we still in this WIP stage > till now? It should be quite easy to finish the final UI in a single CL, but it > seems we're blocked on UX to finish the mocks? We don't have a dedicated UXer yet, but am in the talks about how the feedback dialog would fit into some of the ongoing desktop ux unification goals (happy to chat offline about some of the discussion). This CL just makes it a bit nicer while I finish wiring up the rest of the dialog.
Description was changed from ========== [MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. ========== to ========== [MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. BUG=640604 ==========
Description was changed from ========== [MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. BUG=640604 ========== to ========== [MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. BUG=640604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Updated strings to reflect changes updates from 640604. https://screenshot.googleplex.com/Ua2EgKxNDeB.png
LGTM, thanks!
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. BUG=640604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Add initial styling to feedback dialog. Small tweaks to current dialog, including text sizing and positioning. BUG=640604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328 Cr-Commit-Position: refs/heads/master@{#422472} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/85cfd05f49f4504cf5014cd1beb18841192b9328 Cr-Commit-Position: refs/heads/master@{#422472} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
