Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2309623002: test picture-ops for savelayer (Closed)

Created:
4 years, 3 months ago by reed1
Modified:
4 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add dox #

Patch Set 3 : proposed fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -2 lines) Patch
M src/core/SkRecordOpts.cpp View 1 2 3 chunks +17 lines, -2 lines 0 comments Download
M tests/RecordOptsTest.cpp View 1 2 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
reed1
4 years, 3 months ago (2016-09-06 11:00:02 UTC) #8
mtklein
lgtm We might consider removing this peephole.
4 years, 3 months ago (2016-09-06 13:51:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309623002/40001
4 years, 3 months ago (2016-09-06 13:53:47 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 13:54:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5a3c528f5661a0d5843ecab9567c40c96a9d881e

Powered by Google App Engine
This is Rietveld 408576698