Import csswg-test@6ef20244c71e0d1dfe0a91d8f78befa25a03d94e

Import csswg-test@6ef20244c71e0d1dfe0a91d8f78befa25a03d94e

Using update-w3c-deps in Chromium cf4d11d63dc2da3b3801e9d63c08f7ab5ec3b7d6.

Committed: https://crrev.com/cbd03536e527661cec18195081be61955346f025
Cr-Commit-Position: refs/heads/master@{#417169}

[qyearsley, 2016-09-04 15:30:21]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-04 15:30:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2016-09-04 15:31:30]

qyearsley@chromium.org changed reviewers:
+ kojii@chromium.org

[qyearsley, 2016-09-04 15:31:31]

Hi kojii, can you take a look at the results for
writing-modes-3/text-combine-upright-line-breaking-rules-001.html in the try
jobs (e.g.
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...)
and see if it makes sense?

[commit-bot: I haz the power, 2016-09-04 16:40:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-04 16:40:27]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-09-05 03:44:27]

Thanks for checking with me, it looks like our import script removes part of the
path incorrectly, see below.

https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html
(right):

https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html:11:
src: url("suppoadobe-fonts/CSSHWOrientationTest.otf");
The path was somehow modified, the original csswg-test has
"support/adobe-fonts/CSSHWOrientationTest.otf" but "rt/" was somehow deleted.

[kojii, 2016-09-06 03:11:37]

or, maybe because the reference file is in a sub folder, it might be hitting a
bug in our import script when a file in sub folder has web-font URL. I can fix
the upstream if we prefer that than investigating/fixing our script, please let
me know if that's the case.

[qyearsley, 2016-09-07 16:57:09]

https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html
(right):

https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html:11:
src: url("suppoadobe-fonts/CSSHWOrientationTest.otf");
On 2016/09/05 at 03:44:27, kojii wrote:
> The path was somehow modified, the original csswg-test has
"support/adobe-fonts/CSSHWOrientationTest.otf" but "rt/" was somehow deleted.

Yeah, that's weird! Perhaps this is a bug in the test importer/converter.

https://github.com/w3c/csswg-test/blob/master/css-writing-modes-3/text-combin...
https://github.com/w3c/csswg-test/blob/master/css-writing-modes-3/reference/t...

[qyearsley, 2016-09-07 20:48:40]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[qyearsley, 2016-09-07 20:49:23]

On 2016/09/07 at 16:57:09, qyearsley wrote:
>
https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html
(right):
> 
>
https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html:11:
src: url("suppoadobe-fonts/CSSHWOrientationTest.otf");
> On 2016/09/05 at 03:44:27, kojii wrote:
> > The path was somehow modified, the original csswg-test has
"support/adobe-fonts/CSSHWOrientationTest.otf" but "rt/" was somehow deleted.
> 
> Yeah, that's weird! Perhaps this is a bug in the test importer/converter.
> 
>
https://github.com/w3c/csswg-test/blob/master/css-writing-modes-3/text-combin...
>
https://github.com/w3c/csswg-test/blob/master/css-writing-modes-3/reference/t...

So, I plan to follow up with this later and try and reproduce the bug.
Meanwhile, for this CL, I've manually fixed the URL in the reference HTML file,
and now the test passes as expected.

[commit-bot: I haz the power, 2016-09-07 20:49:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:25:52]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-09-08 02:22:11]

On 2016/09/07 at 20:49:23, qyearsley wrote:
> On 2016/09/07 at 16:57:09, qyearsley wrote:
> >
https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
> > File
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html
(right):
> > 
> >
https://codereview.chromium.org/2309603003/diff/20001/third_party/WebKit/Layo...
> >
third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/text-combine-upright-line-breaking-rules-001-expected.html:11:
src: url("suppoadobe-fonts/CSSHWOrientationTest.otf");
> > On 2016/09/05 at 03:44:27, kojii wrote:
> > > The path was somehow modified, the original csswg-test has
"support/adobe-fonts/CSSHWOrientationTest.otf" but "rt/" was somehow deleted.
> > 
> > Yeah, that's weird! Perhaps this is a bug in the test importer/converter.
> > 
> >
https://github.com/w3c/csswg-test/blob/master/css-writing-modes-3/text-combin...
> >
https://github.com/w3c/csswg-test/blob/master/css-writing-modes-3/reference/t...
> 
> So, I plan to follow up with this later and try and reproduce the bug.
Meanwhile, for this CL, I've manually fixed the URL in the reference HTML file,
and now the test passes as expected.

Thanks, appreciated. LGTM.

[kojii, 2016-09-08 02:22:34]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-09-08 02:22:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 02:26:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 02:30:10]

Description was changed from

==========
Import csswg-test@6ef20244c71e0d1dfe0a91d8f78befa25a03d94e

Using update-w3c-deps in Chromium cf4d11d63dc2da3b3801e9d63c08f7ab5ec3b7d6.
==========

to

==========
Import csswg-test@6ef20244c71e0d1dfe0a91d8f78befa25a03d94e

Using update-w3c-deps in Chromium cf4d11d63dc2da3b3801e9d63c08f7ab5ec3b7d6.

Committed: https://crrev.com/cbd03536e527661cec18195081be61955346f025
Cr-Commit-Position: refs/heads/master@{#417169}
==========

[commit-bot: I haz the power, 2016-09-08 02:30:11]

Patchset 3 (id:??) landed as
https://crrev.com/cbd03536e527661cec18195081be61955346f025
Cr-Commit-Position: refs/heads/master@{#417169}