Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2309603002: Round results of multiplying QuicBandwidth and QuicTime::Delta rather than truncating. No behavior… (Closed)

Created:
4 years, 3 months ago by Victor Vasiliev
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Round results of multiplying QuicBandwidth and QuicTime::Delta rather than truncating. No behavior change expected. This will result in slightly more accurate time calculations, but should not make any real impact, since we should not be relying on microsecond-level-precision to that extent. Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=640984 Merge internal change: 131334594 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M net/quic/core/congestion_control/rtt_stats_test.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M net/quic/core/quic_bandwidth.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/core/quic_bandwidth_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_time.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/core/quic_time_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
Victor Vasiliev
4 years, 3 months ago (2016-09-03 01:53:39 UTC) #1
Ryan Hamilton
4 years, 3 months ago (2016-09-03 02:00:54 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698