Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2309533002: Revert of Merge method_counts into resource_sizes (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Merge method_counts into resource_sizes (patchset #2 id:20001 of https://codereview.chromium.org/2238243003/ ) Reason for revert: Broke cronet bot (and likely others too). Original issue's description: > Merge method_counts into resource_sizes > > resource_size.py now also reports method counts, so no need > to run method_counts.py separately. > > BUG=609365 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/0aba2c2011d7bf00bd42b42a5b68c3aa19b4e883 TBR=rnephew@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609365 Committed: https://chromium.googlesource.com/chromium/tools/build/+/394f77709c13c2001ce67169355bfdaee649405e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1090 lines, -1361 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 2 chunks +28 lines, -25 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 3 chunks +15 lines, -3 lines 0 comments Download
A scripts/slave/recipe_modules/chromium_android/example.expected/java_method_count_builder_basic.json View 1 chunk +966 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json View 2 chunks +18 lines, -154 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json View 2 chunks +7 lines, -131 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
agrieve
Created Revert of Merge method_counts into resource_sizes
4 years, 3 months ago (2016-09-02 20:30:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309533002/1
4 years, 3 months ago (2016-09-02 20:30:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/394f77709c13c2001ce67169355bfdaee649405e
4 years, 3 months ago (2016-09-02 20:31:07 UTC) #6
agrieve
On 2016/09/02 20:31:07, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 3 months ago (2016-09-02 20:32:03 UTC) #7
agrieve
On 2016/09/02 20:31:07, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 3 months ago (2016-09-02 20:32:03 UTC) #8
agrieve
4 years, 3 months ago (2016-09-04 00:53:40 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2310743002/ by agrieve@chromium.org.

The reason for reverting is: will update when changed.

Powered by Google App Engine
This is Rietveld 408576698