Plumbing through more WebVR presentation code

Plumbing through more WebVR presentation code

Also improved the client/delegate model for managing the GvrApi context in
anticipation of making VrShell the GvrDelegate.

BUG=389343
Committed: https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f
Cr-Commit-Position: refs/heads/master@{#416796}

[bajones, 2016-09-03 19:20:25]

bajones@chromium.org changed reviewers:
+ bshe@chromium.org, klausw@chromium.org, mkwst@chromium.org

[bajones, 2016-09-03 19:20:25]

Yes, I know it's a US/CAN holiday weekend. Prompt reviews are not expected. :)

mkwst@: Please take a look at the (minor) .mojom changes!

bshe@ and/or klausw@: I'd appreciate having someone take a look GVR side of
things, even if it's a bit abstract right now. The intent is to ultimately have
VrShell be the GvrDelegate, since it will actually have ownership of the GvrApi
and GvrLayout.

[Mike West, 2016-09-05 06:55:00]

.mojom LGTM.

[bajones, 2016-09-06 17:54:07]

bajones@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2016-09-06 18:18:31]

https://codereview.chromium.org/2309523003/diff/1/device/vr/android/gvr/gvr_d...
File device/vr/android/gvr/gvr_delegate.cc (right):

https://codereview.chromium.org/2309523003/diff/1/device/vr/android/gvr/gvr_d...
device/vr/android/gvr/gvr_delegate.cc:12: GvrDelegateManager*
g_gvr_delegate_manager = nullptr;
Does this ever get deleted? Who owns this?

[bajones, 2016-09-06 19:57:25]

On 2016/09/06 18:18:31, mthiesse wrote:
>
https://codereview.chromium.org/2309523003/diff/1/device/vr/android/gvr/gvr_d...
> File device/vr/android/gvr/gvr_delegate.cc (right):
> 
>
https://codereview.chromium.org/2309523003/diff/1/device/vr/android/gvr/gvr_d...
> device/vr/android/gvr/gvr_delegate.cc:12: GvrDelegateManager*
> g_gvr_delegate_manager = nullptr;
> Does this ever get deleted? Who owns this?

It owns itself and never really gets deleted. It follows a similar pattern to
the GamepadDataFetcherManager
(https://cs.chromium.org/chromium/src/device/gamepad/gamepad_data_fetcher_mana...)
or the GeolocationDelegate
(https://cs.chromium.org/chromium/src/device/geolocation/geolocation_provider_...).
I could update it to be a leaky base::LazyInstance as in the Geolocation case.

[mthiesse, 2016-09-06 20:10:38]

I would follow the geolocation example for the leaky static instance, it's much
clearer.

lgtm

https://codereview.chromium.org/2309523003/diff/1/device/vr/android/gvr/gvr_d...
File device/vr/android/gvr/gvr_device.cc (right):

https://codereview.chromium.org/2309523003/diff/1/device/vr/android/gvr/gvr_d...
device/vr/android/gvr/gvr_device.cc:88: // TODO(bajones): GVR has a bug that
causes it to return bad render target
FYI: We fix this for VrShell by forcing landscape mode before we initialize gvr.
I expect this option isn't really available to you... so good luck?

You can probably come up with better not-horrifically-wrong values by looking at
the display width/height if you can somehow get that information here. Feel free
to not do that in this CL though.

[mthiesse, 2016-09-06 20:10:40]

I would follow the geolocation example for the leaky static instance, it's much
clearer.

lgtm

[bajones, 2016-09-06 22:45:53]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-06 22:45:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2309523003/#ps20001
(title: "Addressed Michael's feedack")

[commit-bot: I haz the power, 2016-09-06 22:46:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 00:30:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 00:32:58]

Description was changed from

==========
Plumbing through more WebVR presentation code

Also improved the client/delegate model for managing the GvrApi context in
anticipation of making VrShell the GvrDelegate.

BUG=389343
==========

to

==========
Plumbing through more WebVR presentation code

Also improved the client/delegate model for managing the GvrApi context in
anticipation of making VrShell the GvrDelegate.

BUG=389343

Committed: https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f
Cr-Commit-Position: refs/heads/master@{#416796}
==========

[commit-bot: I haz the power, 2016-09-07 00:32:59]

Patchset 2 (id:??) landed as
https://crrev.com/487d1fc5424211ef6fc1b3f5cfc1e5355169339f
Cr-Commit-Position: refs/heads/master@{#416796}