Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2309503002: [Download Home] Pull out DownloadHistoryWrapper.ItemViewHolder (Closed)

Created:
4 years, 3 months ago by gone
Modified:
4 years, 3 months ago
Reviewers:
Theresa
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Home] Pull out DownloadHistoryWrapper.ItemViewHolder Pull ItemViewHolder and the code for setting its views into its own class because it's getting kind of big. BUG=616324 Committed: https://crrev.com/e054e39676920172d46869ec3d0d101233a1405d Cr-Commit-Position: refs/heads/master@{#416375}

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : Comments #

Patch Set 4 : Really uploading this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -91 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java View 4 chunks +3 lines, -86 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemViewHolder.java View 1 2 3 1 chunk +104 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
gone
Nothing crazy going on here.
4 years, 3 months ago (2016-09-02 19:06:04 UTC) #2
Theresa
DownloadHistoryItemViewHolder.java didn't quite make it into the patchset
4 years, 3 months ago (2016-09-02 19:25:31 UTC) #3
Theresa
lgtm
4 years, 3 months ago (2016-09-02 20:43:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309503002/60001
4 years, 3 months ago (2016-09-02 20:43:39 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-02 22:46:16 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 22:49:37 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e054e39676920172d46869ec3d0d101233a1405d
Cr-Commit-Position: refs/heads/master@{#416375}

Powered by Google App Engine
This is Rietveld 408576698