chrome/browser/profiles/profile_downloader_unittest.cc - Issue 23095006: If user profile doesn't contain language setting, default to his Google account settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_downloader_unittest.cc

Issue 23095006: If user profile doesn't contain language setting, default to his Google account settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment on "list of preferred languages". Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/user_manager_impl.cc ('K') | « chrome/browser/profiles/profile_downloader.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_downloader_unittest.cc

diff --git a/chrome/browser/profiles/profile_downloader_unittest.cc b/chrome/browser/profiles/profile_downloader_unittest.cc

index 11646d34984bdb8d7ba3dd672ff00bea6a7cc33e..447ad06c9cde47ae2a782fcb104cfe846cfe98af 100644

--- a/chrome/browser/profiles/profile_downloader_unittest.cc

+++ b/chrome/browser/profiles/profile_downloader_unittest.cc

@@ -36,8 +36,9 @@ class ProfileDownloaderTest : public testing::Test {

bool is_valid) {

string16 parsed_name;

std::string parsed_url;

- bool result = ProfileDownloader::GetProfileNameAndImageURL(

- GetJSonData(name, url), &parsed_name, &parsed_url, 32);

+ std::string parsed_locale;

sail 2013/09/09 22:02:17 could you add a test for this?

Alexander Alekseev 2013/09/11 18:53:02 Done.

+ bool result = ProfileDownloader::ParseProfileJSON(

+ GetJSonData(name, url), &parsed_name, &parsed_url, 32, &parsed_locale);

EXPECT_EQ(is_valid, result);

std::string parsed_name_utf8 = UTF16ToUTF8(parsed_name);

EXPECT_EQ(name, parsed_name_utf8);