Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3432)

Unified Diff: chrome/browser/chromeos/login/user_image_manager_impl.cc

Issue 23095006: If user profile doesn't contain language setting, default to his Google account settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix shared build. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_image_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/user_image_manager_impl.cc b/chrome/browser/chromeos/login/user_image_manager_impl.cc
index f66f0f0bc4f7388c171557d29e30bfa2ed83a301..7f478549c859145dc2f419a2af2f4cf0e20abd8f 100644
--- a/chrome/browser/chromeos/login/user_image_manager_impl.cc
+++ b/chrome/browser/chromeos/login/user_image_manager_impl.cc
@@ -644,6 +644,9 @@ void UserImageManagerImpl::OnProfileDownloadSuccess(
user->email(), downloader->GetProfileFullName());
}
+ ProfileManager::GetDefaultProfile()->
+ SetGPlusProfileLocale(downloader->GetProfileLocale());
Nikita (slow) 2013/08/26 09:26:13 nit: SetGPlusProfileLocale - this method needs to
Alexander Alekseev 2013/09/06 19:52:08 Done.
+
bool requested_image = downloading_profile_image_;
downloading_profile_image_ = false;
if (!requested_image)
@@ -723,6 +726,9 @@ void UserImageManagerImpl::OnProfileDownloadFailure(
AddProfileImageTimeHistogram(kDownloadFailure, profile_image_download_reason_,
delta);
+ ProfileManager::GetDefaultProfile()->
+ SetGPlusProfileLocale(downloader->GetProfileLocale());
Nikita (slow) 2013/08/26 09:26:13 Should this really be called in failure case?
Alexander Alekseev 2013/09/06 19:52:08 Yes. I've commented it in the new patch set.
+
// Retry download after some time if a network error has occured.
if (reason == ProfileDownloaderDelegate::NETWORK_ERROR) {
BrowserThread::PostDelayedTask(

Powered by Google App Engine
This is Rietveld 408576698