If user profile doesn't contain language setting, default to his Google account settings.

chrome/browser/profiles/profile_downloader_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_downloader.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
-std::string GetJSonData(const std::string& name, const std::string& url) {
+std::string GetJSonData(const std::string& name,
+                        const std::string& url,
+                        const std::string& locale) {
   std::stringstream stream;
+  bool started = false;
+
   stream << "{ ";
-  if (!name.empty())
-    stream << "\"name\": \"" << name << "\", ";
-  if (!url.empty())
-    stream << "\"picture\": \"" << url << "\", ";
-  stream << "\"locale\": \"en-US\" }";
+  if (!name.empty()) {
+    stream << "\"name\": \"" << name << "\"";
+    started = true;
+  }
+  if (!url.empty()) {
+    stream << (started ? ", " : "") << "\"picture\": \"" << url << "\"";
+    started = true;
+  }
+
+  if (!locale.empty())
+    stream << (started ? ", " : "") << "\"locale\": \"" << locale << "\"";
+
+  stream << " }";
   return stream.str();
 }
 
 } // namespace
 
 class ProfileDownloaderTest : public testing::Test {
  protected:
   ProfileDownloaderTest() {
   }
 
   virtual ~ProfileDownloaderTest() {
   }
 
-  void VerifyWithNameAndURL(const std::string& name,
-                                   const std::string& url,
-                                   const std::string& expected_url,
-                                   bool is_valid) {
+  void VerifyWithAccountData(const std::string& name,
+                             const std::string& url,
+                             const std::string& expected_url,
+                             const std::string& locale,
+                             bool is_valid) {
     string16 parsed_name;
     std::string parsed_url;
-    bool result = ProfileDownloader::GetProfileNameAndImageURL(
-        GetJSonData(name, url), &parsed_name, &parsed_url, 32);
+    std::string parsed_locale;
+    bool result =
+        ProfileDownloader::ParseProfileJSON(GetJSonData(name, url, locale),
+                                            &parsed_name,
+                                            &parsed_url,
+                                            32,
+                                            &parsed_locale);
     EXPECT_EQ(is_valid, result);
     std::string parsed_name_utf8 = UTF16ToUTF8(parsed_name);
     EXPECT_EQ(name, parsed_name_utf8);
     EXPECT_EQ(expected_url, parsed_url);
+    EXPECT_EQ(locale, parsed_locale);
   }
 };
 
 TEST_F(ProfileDownloaderTest, ParseData) {
   // URL without size specified.
-  VerifyWithNameAndURL(
+  VerifyWithAccountData(
       "Pat Smith",
       "https://example.com/--Abc/AAAAAAAAAAI/AAAAAAAAACQ/Efg/photo.jpg",
       "https://example.com/--Abc/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s32-c/photo.jpg",
+      "en-US",
       true);
 
   // URL with size specified.
-  VerifyWithNameAndURL(
+  VerifyWithAccountData(
       "Pat Smith",
       "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/abc12/s64-c/1234567890.jpg",
       "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/abc12/s32-c/1234567890.jpg",
+      "en-US",
       true);
 
   // URL with unknown format.
-  VerifyWithNameAndURL(
+  VerifyWithAccountData("Pat Smith",
+                        "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/",
+                        "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/",
+                        "en-US",
+                        true);
+
+  // Try different locales.

[sail, 2013/09/11 19:00:38]

join these two comments into one sentence?

[Alexander Alekseev, 2013/09/18 20:21:19]

Done.

+  // URL with size specified.
+  VerifyWithAccountData(
       "Pat Smith",
-      "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/",
-      "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/",
+      "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/abc12/s64-c/1234567890.jpg",
+      "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/abc12/s32-c/1234567890.jpg",
+      "jp",
       true);
 
+  // URL with unknown format.
+  VerifyWithAccountData("Pat Smith",
+                        "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/",
+                        "http://lh0.ggpht.com/-abcd1aBCDEf/AAAA/AAA_A/",
+                        "fr",
+                        true);
+
   // Data with only name.
-  VerifyWithNameAndURL("Pat Smith", std::string(), std::string(), true);
+  VerifyWithAccountData(
+      "Pat Smith", std::string(), std::string(), std::string(), true);
 
   // Data with only URL.
-  VerifyWithNameAndURL(
+  VerifyWithAccountData(
       std::string(),
       "https://example.com/--Abc/AAAAAAAAAAI/AAAAAAAAACQ/Efg/photo.jpg",
       "https://example.com/--Abc/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s32-c/photo.jpg",
+      std::string(),
       true);
 
-  // Data without name or URL.
-  VerifyWithNameAndURL(std::string(), std::string(), std::string(), false);
+  // Data with only locale.
+  VerifyWithAccountData(
+      std::string(), std::string(), std::string(), "fr", false);
+
+  // Data without name or URL or locale.
+  VerifyWithAccountData(
+      std::string(), std::string(), std::string(), std::string(), false);
 
   // Data with an invalid URL.
-  VerifyWithNameAndURL(std::string(), "invalid url", std::string(), false);
+  VerifyWithAccountData(
+      std::string(), "invalid url", std::string(), std::string(), false);
 }
 
 TEST_F(ProfileDownloaderTest, DefaultURL) {
   // Empty URL should be default photo
   EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(std::string()));
   // Picasa default photo
   EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(
       "https://example.com/-4/AAAAAAAAAAA/AAAAAAAAAAE/G/s64-c/photo.jpg"));
   // Not default G+ photo
   EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(
       "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAAAA/G/photo.jpg"));
   // Not default with 6 components
   EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(
       "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/photo.jpg"));
   // Not default with 7 components
   EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(
       "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s32-c/photo.jpg"));
 }