Source/core/rendering/RenderBlock.cpp - Issue 230943003: hitTest should check the location if it is inside borderBoxRect in case of overflow: hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 230943003: hitTest should check the location if it is inside borderBoxRect in case of overflow: hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow.html ('K') | « LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index f5ad8965fa55d8885961e3bd6f963e723e5b8903..7168c5d50687da781d37b4801632ce6459243973 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -2863,7 +2863,8 @@ bool RenderBlock::nodeAtPoint(const HitTestRequest& request, HitTestResult& resu

if (!isRenderView()) {

// Check if we need to do anything at all.

- LayoutRect overflowBox = visualOverflowRect();

+ // If we have clipping, then we can't have any spillout.

+ LayoutRect overflowBox = hasOverflowClip() ? borderBoxRect() : visualOverflowRect();

flipForWritingMode(overflowBox);

overflowBox.moveBy(adjustedLocation);

if (!locationInContainer.intersects(overflowBox))