Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 230943003: hitTest should check the location if it is inside borderBoxRect in case of overflow: hidden (Closed)

Created:
6 years, 8 months ago by pals
Modified:
6 years, 8 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

hitTest should check the location if it is inside borderBoxRect in case of overflow: hidden BUG=110705 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171781

Patch Set 1 #

Total comments: 8

Patch Set 2 : Review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -1 line) Patch
A LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow.html View 1 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
pals
Please review.
6 years, 8 months ago (2014-04-09 15:59:58 UTC) #1
eseidel
What do other browsers do? Does the spec cover this?
6 years, 8 months ago (2014-04-09 18:08:30 UTC) #2
ojan
IMO, the new behavior is clearly correct, but I don't understand our current behavior well ...
6 years, 8 months ago (2014-04-10 01:50:56 UTC) #3
pals
On 2014/04/10 01:50:56, ojan wrote: > IMO, the new behavior is clearly correct, but I ...
6 years, 8 months ago (2014-04-10 12:34:36 UTC) #4
pals
Upadted the patch. Please review. https://codereview.chromium.org/230943003/diff/1/LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow.html File LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow.html (right): https://codereview.chromium.org/230943003/diff/1/LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow.html#newcode3 LayoutTests/fast/overflow/hit-test-overflow-hidden-with-box-shadow.html:3: <head> On 2014/04/10 01:50:56, ...
6 years, 8 months ago (2014-04-10 12:35:32 UTC) #5
pals
Friendly ping.
6 years, 8 months ago (2014-04-13 03:37:22 UTC) #6
pals
Updated the patch and explained the root cause of the issue in case of position: ...
6 years, 8 months ago (2014-04-15 06:19:37 UTC) #7
ojan
lgtm. I think this patch is an improvement. My only concern is that the place ...
6 years, 8 months ago (2014-04-15 22:45:57 UTC) #8
pals
On 2014/04/15 22:45:57, ojan wrote: > lgtm. I think this patch is an improvement. > ...
6 years, 8 months ago (2014-04-16 15:26:44 UTC) #9
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 8 months ago (2014-04-16 15:26:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/230943003/20001
6 years, 8 months ago (2014-04-16 15:26:59 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 17:12:12 UTC) #12
Message was sent while issue was closed. 
Change committed as 171781

Powered by Google App Engine
This is Rietveld 408576698