Fix crashes of some CPU profiler tests on Windows after r16284

Fix crashes of some CPU profiler tests on Windows after r16284

All the tests that started crashing create ProfilerEventsProcessor on the stack. After r16284 SamplingCircularQueue buffer is allocated as a field of the queue instead of separate heap object. This increased self size of ProfilerEventsProcessor by about 1Mb. Windows malloc fails to allocate such an object on the stack and crashes.

BUG=
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16287

[Jakob Kummerow, 2013-08-23 10:25:39]

LGTM with comment.

https://codereview.chromium.org/23093022/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/23093022/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:54: delete processor;
You could use SmartPointer<ProfilerEventsProcessor> (see src/smart-pointers.h)
to avoid manual deletion, but I don't feel strongly about it.

[yurys, 2013-08-23 10:58:18]

On 2013/08/23 10:25:39, Jakob wrote:
> LGTM with comment.
> 
>
https://codereview.chromium.org/23093022/diff/1/test/cctest/test-cpu-profiler.cc
> File test/cctest/test-cpu-profiler.cc (right):
> 
>
https://codereview.chromium.org/23093022/diff/1/test/cctest/test-cpu-profiler...
> test/cctest/test-cpu-profiler.cc:54: delete processor;
> You could use SmartPointer<ProfilerEventsProcessor> (see src/smart-pointers.h)
> to avoid manual deletion, but I don't feel strongly about it.

Wow, smart pointers in v8! Didn't know they exist, updated the test.

Is there a reason SmartPointer is used only in compiler.cc ?

[yurys, 2013-08-23 10:59:37]

Committed patchset #2 manually as r16287.

[Jakob Kummerow, 2013-08-23 11:01:33]

On 2013/08/23 10:58:18, Yury Semikhatsky wrote:
> Wow, smart pointers in v8! Didn't know they exist, updated the test.
> 
> Is there a reason SmartPointer is used only in compiler.cc ?

Probably because too many people didn't know they exist ;-)
More seriously, because they've only been introduced a while ago, and there
hasn't been a large-scale refactoring effort to use them everywhere. I think we
should at least use them in new code when they make sense.

Patch set 2 LGTM.