Site Settings Desktop: Fix issues with entering URL patterns.

chrome/browser/resources/settings/site_settings/add_site_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'add-site-dialog' provides a dialog to add exceptions for a given Content
  * Settings category.
  */
 Polymer({
@@ skipping 22 matching lines @@
   open: function(type) {
     this.allowException = type == settings.PermissionValues.ALLOW;
     this.$.dialog.showModal();
   },
 
   /**
    * Validates that the pattern entered is valid.
    * @private
    */
   validate_: function() {
-    var pattern = this.addPatternWildcard(this.site_);

[Finnur, 2016/09/05 11:23:17]

Adding the wildcard prefix during validate is wrong because once the wildcard
has been added, the pattern is basically always valid (at least that's how the
pattern validation in C++ works, it seems).

[dschuyler, 2016/09/06 18:20:29]

Acknowledged.

-    this.browserProxy.isPatternValid(pattern).then(function(isValid) {
+    this.browserProxy.isPatternValid(this.site_).then(function(isValid) {
       this.$.add.disabled = !isValid;
     }.bind(this));
   },
 
   /** @private */
   onCancelTap_: function() {
     this.$.dialog.cancel();
   },
 
   /**
    * The tap handler for the Add [Site] button (adds the pattern and closes
    * the dialog).
    * @private
    */
   onSubmit_: function() {
     if (this.$.add.disabled)
       return;  // Can happen when Enter is pressed.
     var pattern = this.addPatternWildcard(this.site_);
     this.setCategoryPermissionForOrigin(
         pattern, pattern, this.category, this.allowException ?
             settings.PermissionValues.ALLOW : settings.PermissionValues.BLOCK);
     this.$.dialog.close();
   },
 });