Site Settings Desktop: Fix issues with entering URL patterns.

Site Settings Desktop: Fix issues with entering URL patterns.

BUG=633682, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03
Cr-Commit-Position: refs/heads/master@{#417254}

[Finnur, 2016-09-05 11:19:50]

Description was changed from

==========
Site Settings Desktop: Fix issues with entering URL patterns.

BUG=633682, 614277
==========

to

==========
Site Settings Desktop: Fix issues with entering URL patterns.

BUG=633682, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-09-05 11:23:16]

finnur@chromium.org changed reviewers:
+ dschuyler@chromium.org

[Finnur, 2016-09-05 11:23:17]

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.js (left):

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.js:43: var
pattern = this.addPatternWildcard(this.site_);
Adding the wildcard prefix during validate is wrong because once the wildcard
has been added, the pattern is basically always valid (at least that's how the
pattern validation in C++ works, it seems).

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_settings_behavior.js
(right):

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_settings_behavior.js:400:
return pattern;
When the user manually enters a URL pattern with a wildcard, we don't want to
add an extra one.

[Finnur, 2016-09-05 11:23:37]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 11:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 12:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 12:16:47]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-06 18:20:29]

lgtm

Thanks for the notes :)

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.js (left):

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.js:43: var
pattern = this.addPatternWildcard(this.site_);
On 2016/09/05 11:23:17, Finnur wrote:
> Adding the wildcard prefix during validate is wrong because once the wildcard
> has been added, the pattern is basically always valid (at least that's how the
> pattern validation in C++ works, it seems).

Acknowledged.

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_settings_behavior.js
(right):

https://codereview.chromium.org/2309283002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_settings_behavior.js:400:
return pattern;
On 2016/09/05 11:23:17, Finnur wrote:
> When the user manually enters a URL pattern with a wildcard, we don't want to
> add an extra one.

Acknowledged.

[Finnur, 2016-09-08 09:46:14]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2016-09-08 09:46:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 11:36:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 11:39:37]

Description was changed from

==========
Site Settings Desktop: Fix issues with entering URL patterns.

BUG=633682, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Fix issues with entering URL patterns.

BUG=633682, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03
Cr-Commit-Position: refs/heads/master@{#417254}
==========

[commit-bot: I haz the power, 2016-09-08 11:39:38]

Patchset 1 (id:??) landed as
https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03
Cr-Commit-Position: refs/heads/master@{#417254}