Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2309273002: Disable some DumpAccessibilityTreeTest.Accessibility test on Windows (Closed)

Created:
4 years, 3 months ago by magjed_chromium
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable some DumpAccessibilityTreeTest.Accessibility test on Windows NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=dmazzoni@chromium.org BUG=chromium:643954 Committed: https://crrev.com/b7a4685cc72298483cde031c401007f78538d429 Cr-Commit-Position: refs/heads/master@{#416527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 2 chunks +30 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309273002/1
4 years, 3 months ago (2016-09-05 11:14:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 11:14:41 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7a4685cc72298483cde031c401007f78538d429 Cr-Commit-Position: refs/heads/master@{#416527}
4 years, 3 months ago (2016-09-05 11:16:33 UTC) #9
dmazzoni
4 years, 3 months ago (2016-09-07 19:32:45 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2320673003/ by dmazzoni@chromium.org.

The reason for reverting is: Re-enabling these tests because the change that
caused the try flakes was reverted here:

https://codereview.chromium.org/2302353005

.

Powered by Google App Engine
This is Rietveld 408576698