[Mac] Map ContextMenu key to corresponding DomKey and keyCode

[Mac] Map ContextMenu key to corresponding DomKey and keyCode

There are existing DomKey and keyCode values for ContextMenu, we
should support them on all platforms.
(Even though ContextMenu key is not natively supported on mac OS,
it could have other usage such as remote apps.)

DomCode is already mapped to corresponding value.

After CL we will match FireFox.

BUG=168845
Committed: https://crrev.com/6100a1815f84660e7a6409383733ef47ea72867c
Cr-Commit-Position: refs/heads/master@{#417091}

[chongz, 2016-09-06 21:06:16]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 21:06:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:05:57]

Dry run: This issue passed the CQ dry run.

[chongz, 2016-09-06 22:21:09]

Description was changed from

==========
[Mac] Map ContextMenu key to corresponding DomKey and keyCode

We should map ContextMenu key to corresponding DomKey and keyCode as
there exist appreciate values. DomCode is already mapped.
(Even though mac OS doesn't natively support context meny key)

After CL we will match FireFox.

BUG=168845
==========

to

==========
[Mac] Map ContextMenu key to corresponding DomKey and keyCode

There are existing DomKey and keyCode values for ContextMenu, we
should support them on all platforms.
(Even though ContextMenu key is not natively supported on mac OS,
it could have other usage such as remote apps.)

DomCode is already mapped to corresponding value.

After CL we will match FireFox.

BUG=168845
==========

[chongz, 2016-09-06 22:21:49]

chongz@chromium.org changed reviewers:
+ wez@chromium.org

[chongz, 2016-09-06 22:21:49]

wez@ PTAL, thanks!

[Wez, 2016-09-06 23:23:22]

lgtm

[chongz, 2016-09-06 23:48:34]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:49:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 23:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:55:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chongz, 2016-09-07 17:14:31]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org

[chongz, 2016-09-07 17:14:31]

dtapuska@ PTAL at "web_input_event_builders_mac_unittest.mm", thanks!

[dtapuska, 2016-09-07 17:53:25]

lgtm % nit.

Have you verified that the "Windows 95 key".. ie; the App Key Left produces the
unknown value still and not ContextMenu?

https://codereview.chromium.org/2309253006/diff/1/content/browser/renderer_ho...
File
content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm
(right):

https://codereview.chromium.org/2309253006/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm:574:
EXPECT_EQ(ui::DomKey::CONTEXT_MENU, web_event.domKey) << web_event.domKey;
I don't think you need the "<< web_event.domKey" or on the line below. EXPECT_EQ
will generate the sufficient info if it doesn't match.

[chongz, 2016-09-07 20:09:17]

On 2016/09/07 17:53:25, dtapuska wrote:
> lgtm % nit.
> 
> Have you verified that the "Windows 95 key".. ie; the App Key Left produces
the
> unknown value still and not ContextMenu?

I couldn't find a physical keyboard or image with "Windows 95 key" or App Key
Left...

But I think it's safe since we already have the DomCode map |0x006e =>
CONTEXT_MENU|, so the DomKey is just matching DomCode.

See DomCode map:
https://cs.chromium.org/chromium/src/ui/events/keycodes/dom/keycode_converter...

> 
>
https://codereview.chromium.org/2309253006/diff/1/content/browser/renderer_ho...
> File
> content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm
> (right):
> 
>
https://codereview.chromium.org/2309253006/diff/1/content/browser/renderer_ho...
>
content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm:574:
> EXPECT_EQ(ui::DomKey::CONTEXT_MENU, web_event.domKey) << web_event.domKey;
> I don't think you need the "<< web_event.domKey" or on the line below.
EXPECT_EQ
> will generate the sufficient info if it doesn't match.

Done.

[chongz, 2016-09-07 21:28:48]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-09-07 21:28:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2309253006/#ps20001
(title: "dtapuska's review, remove unnecessary debug info")

[commit-bot: I haz the power, 2016-09-07 21:29:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 22:21:40]

Description was changed from

==========
[Mac] Map ContextMenu key to corresponding DomKey and keyCode

There are existing DomKey and keyCode values for ContextMenu, we
should support them on all platforms.
(Even though ContextMenu key is not natively supported on mac OS,
it could have other usage such as remote apps.)

DomCode is already mapped to corresponding value.

After CL we will match FireFox.

BUG=168845
==========

to

==========
[Mac] Map ContextMenu key to corresponding DomKey and keyCode

There are existing DomKey and keyCode values for ContextMenu, we
should support them on all platforms.
(Even though ContextMenu key is not natively supported on mac OS,
it could have other usage such as remote apps.)

DomCode is already mapped to corresponding value.

After CL we will match FireFox.

BUG=168845
==========

[commit-bot: I haz the power, 2016-09-07 22:21:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 22:24:21]

Description was changed from

==========
[Mac] Map ContextMenu key to corresponding DomKey and keyCode

There are existing DomKey and keyCode values for ContextMenu, we
should support them on all platforms.
(Even though ContextMenu key is not natively supported on mac OS,
it could have other usage such as remote apps.)

DomCode is already mapped to corresponding value.

After CL we will match FireFox.

BUG=168845
==========

to

==========
[Mac] Map ContextMenu key to corresponding DomKey and keyCode

There are existing DomKey and keyCode values for ContextMenu, we
should support them on all platforms.
(Even though ContextMenu key is not natively supported on mac OS,
it could have other usage such as remote apps.)

DomCode is already mapped to corresponding value.

After CL we will match FireFox.

BUG=168845

Committed: https://crrev.com/6100a1815f84660e7a6409383733ef47ea72867c
Cr-Commit-Position: refs/heads/master@{#417091}
==========

[commit-bot: I haz the power, 2016-09-07 22:24:23]

Patchset 2 (id:??) landed as
https://crrev.com/6100a1815f84660e7a6409383733ef47ea72867c
Cr-Commit-Position: refs/heads/master@{#417091}