Retrieve driver information in WinRT WebMIDI backend

Retrieve driver information in WinRT WebMIDI backend

Now MidiManagerWinrt retrieves driver manufacturer and version of each MIDI
port through Setup API.

BUG=512433, 642604
R=toyoshim@chromium.org

Committed: https://crrev.com/a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0
Cr-Commit-Position: refs/heads/master@{#416607}

[Shao-Chuan Lee, 2016-09-05 09:34:49]

Tentative implementation to retrieve driver info. According to design shown in
"Remarks" section of
https://msdn.microsoft.com/en-us/library/windows/apps/windows.devices.enumera...,
it seems that one cannot retrieve the underlying Device of a DeviceInterface, so
we have to try with different APIs.

In this implementation the device instance ID is extracted from the device
interface ID, for example:

DeviceInterface ID:
\\?\SWD#MMDEVAPI#MIDII_60F39FCA.P_0002#{504be32c-ccf6-4d2c-b73f-6f8b3747e22b}
Device (instance) ID: SWD\MMDEVAPI\MIDII_60F39FCA.P_0002

With the device instance ID it's possible to retrieve driver information from
Setup API. However the driver enumeration takes much time (hundreds of ms), and
this approach is only tested with the Microsoft stock driver (which seems to be
the only WinRT-ready MIDI driver until now).

Currently there are already usages of Setup API in base/win/win_util.cc, and no
extra dependencies is required.

[Takashi Toyoshima, 2016-09-06 05:45:57]

lgtm with minor requests for adding comments.

https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager...
media/midi/midi_manager_winrt.cc:278: void GetDriverInfoFromDeviceId(const
std::string& dev_id,
Can you leave a comment for this function, that shows example dev_id string?
That will help other developers to understand what following code want to do.

Also in the comment, can you explain this function does not touch out_* if it
fails to parse?

[Shao-Chuan Lee, 2016-09-06 06:57:16]

https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager...
media/midi/midi_manager_winrt.cc:278: void GetDriverInfoFromDeviceId(const
std::string& dev_id,
On 2016/09/06 05:45:57, toyoshim wrote:
> Can you leave a comment for this function, that shows example dev_id string?
> That will help other developers to understand what following code want to do.
> 
> Also in the comment, can you explain this function does not touch out_* if it
> fails to parse?

Done.

[Shao-Chuan Lee, 2016-09-06 06:57:20]

The CQ bit was checked by shaochuan@chromium.org

[Shao-Chuan Lee, 2016-09-06 06:57:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/2309253002/#ps20002
(title: "comments, SetupDiEnumDriverInfo fail log")

[commit-bot: I haz the power, 2016-09-06 06:57:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 07:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 07:03:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shao-Chuan Lee, 2016-09-06 07:10:54]

The CQ bit was checked by shaochuan@chromium.org

[Shao-Chuan Lee, 2016-09-06 07:10:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/2309253002/#ps50001
(title: "move comment")

[Takashi Toyoshima, 2016-09-06 07:11:09]

style error seems to cause a presubmit check error.

https://codereview.chromium.org/2309253002/diff/20002/media/midi/midi_manager...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2309253002/diff/20002/media/midi/midi_manager...
media/midi/midi_manager_winrt.cc:288: //
\\?\SWD#MMDEVAPI#MIDII_60F39FCA.P_0002#{504be32c-ccf6-4d2c-b73f-6f8b3747e22b}
Ah, this comment line is over the 80 characters limit.

[commit-bot: I haz the power, 2016-09-06 07:11:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 08:42:28]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-09-06 08:44:24]

Description was changed from

==========
Retrieve driver information in WinRT WebMIDI backend

Now MidiManagerWinrt retrieves driver manufacturer and version of each MIDI
port through Setup API.

BUG=512433,642604
R=toyoshim@chromium.org
==========

to

==========
Retrieve driver information in WinRT WebMIDI backend

Now MidiManagerWinrt retrieves driver manufacturer and version of each MIDI
port through Setup API.

BUG=512433,642604
R=toyoshim@chromium.org

Committed: https://crrev.com/a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0
Cr-Commit-Position: refs/heads/master@{#416607}
==========

[commit-bot: I haz the power, 2016-09-06 08:44:25]

Patchset 4 (id:??) landed as
https://crrev.com/a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0
Cr-Commit-Position: refs/heads/master@{#416607}