Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2309253002: Retrieve driver information in WinRT WebMIDI backend (Closed)

Created:
4 years, 3 months ago by Shao-Chuan Lee
Modified:
4 years, 3 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retrieve driver information in WinRT WebMIDI backend Now MidiManagerWinrt retrieves driver manufacturer and version of each MIDI port through Setup API. BUG=512433, 642604 R=toyoshim@chromium.org Committed: https://crrev.com/a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0 Cr-Commit-Position: refs/heads/master@{#416607}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : comments, SetupDiEnumDriverInfo fail log #

Total comments: 1

Patch Set 4 : move comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -4 lines) Patch
M media/midi/midi_manager_winrt.cc View 1 2 3 4 chunks +85 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Shao-Chuan Lee
Tentative implementation to retrieve driver info. According to design shown in "Remarks" section of https://msdn.microsoft.com/en-us/library/windows/apps/windows.devices.enumeration.deviceinformationkind.aspx, ...
4 years, 3 months ago (2016-09-05 09:34:49 UTC) #1
Takashi Toyoshima
lgtm with minor requests for adding comments. https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager_winrt.cc File media/midi/midi_manager_winrt.cc (right): https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager_winrt.cc#newcode278 media/midi/midi_manager_winrt.cc:278: void GetDriverInfoFromDeviceId(const ...
4 years, 3 months ago (2016-09-06 05:45:57 UTC) #2
Shao-Chuan Lee
https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager_winrt.cc File media/midi/midi_manager_winrt.cc (right): https://codereview.chromium.org/2309253002/diff/20001/media/midi/midi_manager_winrt.cc#newcode278 media/midi/midi_manager_winrt.cc:278: void GetDriverInfoFromDeviceId(const std::string& dev_id, On 2016/09/06 05:45:57, toyoshim wrote: ...
4 years, 3 months ago (2016-09-06 06:57:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309253002/20002
4 years, 3 months ago (2016-09-06 06:57:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/253319)
4 years, 3 months ago (2016-09-06 07:03:27 UTC) #8
Takashi Toyoshima
style error seems to cause a presubmit check error. https://codereview.chromium.org/2309253002/diff/20002/media/midi/midi_manager_winrt.cc File media/midi/midi_manager_winrt.cc (right): https://codereview.chromium.org/2309253002/diff/20002/media/midi/midi_manager_winrt.cc#newcode288 media/midi/midi_manager_winrt.cc:288: ...
4 years, 3 months ago (2016-09-06 07:11:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309253002/50001
4 years, 3 months ago (2016-09-06 07:11:10 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 3 months ago (2016-09-06 08:42:28 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 08:44:25 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0
Cr-Commit-Position: refs/heads/master@{#416607}

Powered by Google App Engine
This is Rietveld 408576698