Issue 230923005: FYI -- apparently, there are more bugs...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 230923005: FYI -- apparently, there are more bugs... (Closed)

Created:
6 years, 8 months ago by rossberg

Modified:
6 years, 8 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

More tests for Union & Intersect Some fixes of corner cases on the way R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20684

Patch Set 2 : Completed #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+428 lines, -324 lines)			Patch
M	src/types.h	View	1	1 chunk	+2 lines, -2 lines	1 comment	Download
M	src/types.cc	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download
M	test/cctest/test-types.cc	View	1	37 chunks	+419 lines, -318 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

This is now ready for review. More to come in another CL.

6 years, 8 months ago (2014-04-10 16:12:20 UTC) #2

Benedikt Meurer

LGTM, nice work! https://codereview.chromium.org/230923005/diff/20001/src/types.h File src/types.h (right): https://codereview.chromium.org/230923005/diff/20001/src/types.h#newcode108 src/types.h:108: // especially with respect to the ...

6 years, 8 months ago (2014-04-10 16:49:07 UTC) #3

rossberg

6 years, 8 months ago (2014-04-11 11:53:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20684 (tree was closed).

Expand Messages | Collapse Messages

Issue 230923005: FYI -- apparently, there are more bugs... (Closed)

Description

Patch Set 1 #

Patch Set 2 : Completed #

Messages