Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2309203002: [turbofan] BytecodeGraphBuilder was incorrectly tenuring most CreateClosure allocations (Closed)

Created:
4 years, 3 months ago by ofrobots
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] BytecodeGraphBuilder was incorrectly tenuring most CreateClosure allocations R=bmeurer@chromium.org, rmcilroy@chromium.org Committed: https://crrev.com/cf3a4a7087974840faab2a9366a517f3f5b38bd6 Cr-Commit-Position: refs/heads/master@{#39148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
ofrobots
4 years, 3 months ago (2016-09-05 05:54:52 UTC) #1
Benedikt Meurer
Awesome, thanks for the investigation. LGTM. (Tweaked the subject a bit.)
4 years, 3 months ago (2016-09-05 05:58:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309203002/1
4 years, 3 months ago (2016-09-05 05:58:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 06:22:21 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf3a4a7087974840faab2a9366a517f3f5b38bd6 Cr-Commit-Position: refs/heads/master@{#39148}
4 years, 3 months ago (2016-09-05 06:22:55 UTC) #10
rmcilroy
4 years, 3 months ago (2016-09-05 07:55:40 UTC) #11
Message was sent while issue was closed.
Thanks for fixing this!

Powered by Google App Engine
This is Rietveld 408576698