third_party/WebKit/Source/wtf/ThreadSpecific.h - Issue 2309153002: Remove RenderThreadImpl::Shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/ThreadSpecific.h

Issue 2309153002: Remove RenderThreadImpl::Shutdown (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/ThreadSpecific.h

diff --git a/third_party/WebKit/Source/wtf/ThreadSpecific.h b/third_party/WebKit/Source/wtf/ThreadSpecific.h

index 82f2144132138057f3ca924f9c1d4a1ae370fb75..5d7f6d26a9eba250c76907a791b1e34b80de2c5d 100644

--- a/third_party/WebKit/Source/wtf/ThreadSpecific.h

+++ b/third_party/WebKit/Source/wtf/ThreadSpecific.h

@@ -224,7 +224,9 @@ inline void ThreadSpecific<T>::set(T* ptr) {

template <typename T>

inline void ThreadSpecific<T>::destroy(void* ptr) {

- if (isShutdown())

+ // Never call destructors on the main thread.

+ // This is fine because Blink no longer has a graceful shutdown sequence.

+ if (isMainThread())

return;

Data* data = static_cast<Data*>(ptr);