Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: test/cctest/cctest.status

Issue 230913002: Fix test expectations for nosnap windows. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index e3edab5d5d9cc11e39cc73a632bb71cf9637a760..a567b8fe7121a2433886afc61d78202f50a0418c 100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -125,10 +125,15 @@
['no_snap == True', {
# BUG(3215)
'test-lockers/MultithreadedParallelIsolates': [PASS, FAIL],
+}], # 'no_snap == True'
+##############################################################################
+# TODO(machenbach): Fix application of '*'. Nosnap windows needs a separate
+# section to not overwrite the expectations for TestThatAlwaysFails.
+['no_snap == True and system == windows', {
# Windows doesn't support nosnap mode.
- 'test-serialize/*': [PASS, ['system == windows', SKIP]],
-}], # 'no_snap == True'
+ 'test-serialize/*': [SKIP],
+}], # 'no_snap == True and system == windows'
##############################################################################
['system == windows', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698