Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2309013002:
[GeometryInterface] Add fromFloat32Array & fromFloat64Array function (Closed)
|
Created:
4 years, 3 months ago by Hwanseung Lee Modified:
4 years, 3 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hwanseung Lee(hs1217.lee), rwlbuis, sof Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[GeometryInterface] Add fromFloat32Array & fromFloat64Array function
Return the result of invoking create a matrix of type
DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of
numbers taking the values from Float32Array or Float64Array in the provided order.
If array has 6 elements, Return a 2d matrix.
If array has 16 elements, Return a 3d matrix.
Otherwise, Throw a TypeError exception.
spec list:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array
https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array
https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array
BUG=388780
Committed: https://crrev.com/233ec454166d493cfab7aa31a530b45e7c2f2956
Cr-Commit-Position: refs/heads/master@{#417943}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Implement fromFloat32Array & fromFloat64Array function in DOMMatrix & DOMMatrixReadOnly. #
Total comments: 8
Patch Set 3 : fix a some test. #
Total comments: 2
Patch Set 4 : [GeometryInterface] Add fromFloat32Array & fromFloat64Array function #
Total comments: 3
Patch Set 5 : [GeometryInterface] Add fromFloat32Array & fromFloat64Array function #Patch Set 6 : [GeometryInterface] Add fromFloat32Array & fromFloat64Array function #Messages
Total messages: 36 (16 generated)
Description was changed from ========== Implement fromFloat32Array & fromFloat64Array function in DOMMatrix & DOMMatrixReadOnly. Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== Implement fromFloat32Array & fromFloat64Array function in DOMMatrix & DOMMatrixReadOnly. Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ==========
hs1217.lee@samsung.com changed reviewers: + dominicc@chromium.org, jinho.bang@samsung.com
@dominicc, zino Please take a look. thank you.
Also, the first line(subject line) should be shorter than 72 characters. https://codereview.chromium.org/2309013002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right): https://codereview.chromium.org/2309013002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:49: if (float32Array->length() == 6) { This logic is duplicated with below constructor. (and another constructor taking Vector<double> as parameter) Can we use template instead of duplicated codes?
@zino, dominicc PTAL again. https://codereview.chromium.org/2309013002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right): https://codereview.chromium.org/2309013002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:49: if (float32Array->length() == 6) { On 2016/09/04 23:11:53, zino wrote: > This logic is duplicated with below constructor. (and another constructor taking > Vector<double> as parameter) > > Can we use template instead of duplicated codes? i did resolve it.
Looks good but could you update commit description as well? The first line(subject line) should be shorter than 72 bytes. Thank you!
Description was changed from ========== Implement fromFloat32Array & fromFloat64Array function in DOMMatrix & DOMMatrixReadOnly. Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== [GeometryInterface]add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ==========
Description was changed from ========== [GeometryInterface]add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== [GeometryInterface] add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ==========
Description was changed from ========== [GeometryInterface] add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ==========
On 2016/09/05 16:59:25, zino wrote: > Looks good but could you update commit description as well? > > The first line(subject line) should be shorter than 72 bytes. > > Thank you! i did fix a first line. thank you.
Some comments inline. Could you simplify the description a bit? I think if all of the spec links come at the end and you're not referring to specific ones, just forget the [1], [2], ... business and just write a list of them! https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html (right): https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:64: var float32Array = new Float32Array([1, 2, 3, 3, 2, 1]); Why not use six distinct values? https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:76: var float64Array = new Float64Array([1, 2, 3, 3.1, 2, 1]); Is there a 64-bit value you could use to verify that the numbers are handled as 64-bit floats? ie something which isn't representable as a 32-bit float? (Is 3.1 one of those? Maybe comment.) https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:182: assert_throws(new TypeError(), function() { DOMMatrix.fromFloat64Array(new Float64Array(15)); }, Could we add tests for 0, 1, 5, 7, 15, 17 and "large" (65K?) elements? https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right): https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:41: exceptionState.throwTypeError("An invalid number sequence is specified. The sequence must contain 6 elements for 2D matrix and 16 elements for 3D matrix."); and 16 elements -> or 16 elements Saying 'and' here implies you need 16+6=22 elements. 2D matrix -> a 2D matrix; 3D matrix -> a 3D matrix "is specified" is a bit awkward because it is passive voice. Maybe shorter is better; just omit it the first sentence? Below too.
Description was changed from ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. refer to detail spec([1],[2],[3],[4]) [1]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array [2]=https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array [3]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array [4]=https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ==========
Description was changed from ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from Float32Array or Float64Array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ==========
@dominicc, zino could you review again? thank you. https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html (right): https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:64: var float32Array = new Float32Array([1, 2, 3, 3, 2, 1]); On 2016/09/06 17:07:22, dominicc (traveling) wrote: > Why not use six distinct values? Done. https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:76: var float64Array = new Float64Array([1, 2, 3, 3.1, 2, 1]); On 2016/09/06 17:07:22, dominicc (traveling) wrote: > Is there a 64-bit value you could use to verify that the numbers are handled as > 64-bit floats? ie something which isn't representable as a 32-bit float? (Is 3.1 > one of those? Maybe comment.) Done. https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:182: assert_throws(new TypeError(), function() { DOMMatrix.fromFloat64Array(new Float64Array(15)); }, On 2016/09/06 17:07:22, dominicc (traveling) wrote: > Could we add tests for 0, 1, 5, 7, 15, 17 and "large" (65K?) elements? Done. https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right): https://codereview.chromium.org/2309013002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:41: exceptionState.throwTypeError("An invalid number sequence is specified. The sequence must contain 6 elements for 2D matrix and 16 elements for 3D matrix."); On 2016/09/06 17:07:22, dominicc (traveling) wrote: > and 16 elements -> or 16 elements > > Saying 'and' here implies you need 16+6=22 elements. > > 2D matrix -> a 2D matrix; 3D matrix -> a 3D matrix > > "is specified" is a bit awkward because it is passive voice. Maybe shorter is > better; just omit it the first sentence? > > Below too. Done.
https://codereview.chromium.org/2309013002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html (right): https://codereview.chromium.org/2309013002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:182: assert_throws(new TypeError(), function() { DOMMatrix.fromFloat32Array(new Float32Array(0)); }, Ah, this isn't exactly what I meant. The numbers in the array aren't so important; it's the number of elements in the arrays. I basically think it would be great to test arrays with 0, 1, ... numbers of *elements* to exercise the size == 6, size == 16, etc. branches of the code.
@dominicc i did fix test. could you review again? but i'm not sure. it is whether the same as your idea or not. if it were different with your thoughts, please explain again. thank you. https://codereview.chromium.org/2309013002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html (right): https://codereview.chromium.org/2309013002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:182: assert_throws(new TypeError(), function() { DOMMatrix.fromFloat32Array(new Float32Array(0)); }, On 2016/09/07 17:44:31, dominicc (traveling) wrote: > Ah, this isn't exactly what I meant. The numbers in the array aren't so > important; it's the number of elements in the arrays. I basically think it would > be great to test arrays with 0, 1, ... numbers of *elements* to exercise the > size == 6, size == 16, etc. branches of the code. Done.
https://codereview.chromium.org/2309013002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html (right): https://codereview.chromium.org/2309013002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:182: assert_throws(new TypeError(), function() { DOMMatrix.fromFloat32Array(new Float32Array([1, 2, ,3, 4, 5])); }, Hmm, these test looks weird. [1, 2, , 3, 4, 5] == [1, 2, NaN, 3, 4, 5] Then, the length will be 6. The exception is due to NaN.
https://codereview.chromium.org/2309013002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html (right): https://codereview.chromium.org/2309013002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:182: assert_throws(new TypeError(), function() { DOMMatrix.fromFloat32Array(new Float32Array([1, 2, ,3, 4, 5])); }, Ah, Sorry. This is not exception. There will be no problem even if taking NaN. Anyway, this test will be failed because the length is 6.
Patchset #5 (id:80001) has been deleted
https://codereview.chromium.org/2309013002/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html (right): https://codereview.chromium.org/2309013002/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix.html:182: assert_throws(new TypeError(), function() { DOMMatrix.fromFloat32Array(new Float32Array([1, 2, ,3, 4, 5])); }, On 2016/09/08 18:09:40, zino wrote: > Ah, Sorry. > > This is not exception. There will be no problem even if taking NaN. > > Anyway, this test will be failed because the length is 6. actually it is typo. i did remove comma of front 3.
lgtm but please wait for dominic's review.
The CQ bit was checked by dominicc@chromium.org
lgtm Yeah, that is what I meant. Thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hs1217.lee@samsung.com
The CQ bit was checked by hs1217.lee@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from jinho.bang@samsung.com, dominicc@chromium.org Link to the patchset: https://codereview.chromium.org/2309013002/#ps120001 (title: "[GeometryInterface] Add fromFloat32Array & fromFloat64Array function")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from Float32Array or Float64Array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from Float32Array or Float64Array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from Float32Array or Float64Array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 ========== to ========== [GeometryInterface] Add fromFloat32Array & fromFloat64Array function Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from Float32Array or Float64Array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 Committed: https://crrev.com/233ec454166d493cfab7aa31a530b45e7c2f2956 Cr-Commit-Position: refs/heads/master@{#417943} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/233ec454166d493cfab7aa31a530b45e7c2f2956 Cr-Commit-Position: refs/heads/master@{#417943} |
