Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2309003002: Fix gn check in content_unittest when enable_webrtc=false (Closed)

Created:
4 years, 3 months ago by mbjorge
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn check in content_unittest when enable_webrtc=false BUG=643904 TEST=gn check Change-Id: Ia57a7f4e9df39e117cb7995cc1ab931fc854be32 Committed: https://crrev.com/65250ec7ef20e67d5eabb7d7857a124f6918694b Cr-Commit-Position: refs/heads/master@{#416677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mbjorge
4 years, 3 months ago (2016-09-03 05:19:17 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 3 months ago (2016-09-03 06:14:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309003002/1
4 years, 3 months ago (2016-09-06 17:19:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 18:30:51 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:34:48 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/65250ec7ef20e67d5eabb7d7857a124f6918694b
Cr-Commit-Position: refs/heads/master@{#416677}

Powered by Google App Engine
This is Rietveld 408576698