Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2308983002: Revert "Refactor how we read global-type-inference data from ssa" (Closed)

Created:
4 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Refactor how we read global-type-inference data from ssa" This reverts commit a319239145fc65ba237489061f1a173fc42914f9. There were some tests that failed, I'll retry this again once I investigate the underlying issue. BUG= Committed: https://github.com/dart-lang/sdk/commit/38482e555f02f1a3aff6148363c92be32fe7e8cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -171 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 24 chunks +40 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 4 chunks +54 lines, -99 lines 0 comments Download
M tests/compiler/dart2js/arithmetic_simplification_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 38482e555f02f1a3aff6148363c92be32fe7e8cf (presubmit successful).
4 years, 3 months ago (2016-09-03 04:06:36 UTC) #2
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-03 04:07:01 UTC) #4
Siggi Cherem (dart-lang)
tbr
4 years, 3 months ago (2016-09-03 04:07:12 UTC) #5
sra1
4 years, 3 months ago (2016-09-03 14:25:28 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698