Revert of Inline core HTML and SVG sources in the GN build.

Revert of Inline core HTML and SVG sources in the GN build. (patchset #1 id:1 of https://codereview.chromium.org/2299143005/ )

Reason for revert:
This broke official builds, see https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10455 :

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm.

Original issue's description:
> Inline core SVG sources in the GN build.
>
> This adds targets in the corresponding directories where the various SVG files
> live. The SVG files are kept in separate targets in the "layout" and "style"
> subdirectories so that the current separation of SVG code is maintained.
>
> TBR=dpranke
>
> Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
> Cr-Commit-Position: refs/heads/master@{#416283}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/84dbf69d4c07a013d8f7e0278287a433bf5fd927
Cr-Commit-Position: refs/heads/master@{#416439}

[Nico, 2016-09-03 03:23:27]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-09-03 03:23:28]

Created Revert of Inline core HTML and SVG sources in the GN build.

[commit-bot: I haz the power, 2016-09-03 03:23:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 03:24:05]

Failed to apply patch for third_party/WebKit/Source/core/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/BUILD.gn:149
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/BUILD.gn' with conflicts.
  U third_party/WebKit/Source/core/BUILD.gn

Patch:       third_party/WebKit/Source/core/BUILD.gn
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn
b/third_party/WebKit/Source/core/BUILD.gn
index
ca8fa6c778b19b1dbe754e12c0c1814756852bca..2ff96bde729d37b07f61b0494b296895b5dcf8d2
100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -149,16 +149,14 @@
     "//v8",
   ]
   deps = [
+    ":html",
     ":remaining",
     ":rendering",
+    ":svg",
     "//third_party/WebKit/Source/core/dom",
     "//third_party/WebKit/Source/core/events",
-    "//third_party/WebKit/Source/core/html",
     "//third_party/WebKit/Source/core/input",
-    "//third_party/WebKit/Source/core/layout/svg",
     "//third_party/WebKit/Source/core/observer",
-    "//third_party/WebKit/Source/core/style:svg",
-    "//third_party/WebKit/Source/core/svg",
   ]
 
   if (is_win && is_debug && is_component_build) {
@@ -169,6 +167,30 @@
   }
 
   public_configs = [ ":core_include_dirs" ]
+}
+
+target(core_link_large_target_type, "html") {
+  sources = rebase_path(webcore_html_files, ".", "//")
+
+  configs -= core_config_remove
+  configs += core_config_add
+
+  deps = [
+    ":core_generated",
+    ":prerequisites",
+  ]
+}
+
+target(core_link_large_target_type, "svg") {
+  sources = rebase_path(webcore_svg_files, ".", "//")
+
+  configs -= core_config_remove
+  configs += core_config_add
+
+  deps = [
+    ":core_generated",
+    ":prerequisites",
+  ]
 }
 
 target(core_link_large_target_type, "remaining") {

[Nico, 2016-09-03 03:36:08]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-03 03:36:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:37:08]

Description was changed from

==========
Revert of Inline core HTML and SVG sources in the GN build. (patchset #1 id:1 of
https://codereview.chromium.org/2299143005/ )

Reason for revert:
This broke official builds, see
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm.

Original issue's description:
> Inline core SVG sources in the GN build.
> 
> This adds targets in the corresponding directories where the various SVG files
> live. The SVG files are kept in separate targets in the "layout" and "style"
> subdirectories so that the current separation of SVG code is maintained.
> 
> TBR=dpranke
> 
> Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
> Cr-Commit-Position: refs/heads/master@{#416283}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Inline core HTML and SVG sources in the GN build. (patchset #1 id:1 of
https://codereview.chromium.org/2299143005/ )

Reason for revert:
This broke official builds, see
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm.

Original issue's description:
> Inline core SVG sources in the GN build.
> 
> This adds targets in the corresponding directories where the various SVG files
> live. The SVG files are kept in separate targets in the "layout" and "style"
> subdirectories so that the current separation of SVG code is maintained.
> 
> TBR=dpranke
> 
> Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
> Cr-Commit-Position: refs/heads/master@{#416283}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-03 03:37:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-03 03:38:57]

Description was changed from

==========
Revert of Inline core HTML and SVG sources in the GN build. (patchset #1 id:1 of
https://codereview.chromium.org/2299143005/ )

Reason for revert:
This broke official builds, see
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm.

Original issue's description:
> Inline core SVG sources in the GN build.
> 
> This adds targets in the corresponding directories where the various SVG files
> live. The SVG files are kept in separate targets in the "layout" and "style"
> subdirectories so that the current separation of SVG code is maintained.
> 
> TBR=dpranke
> 
> Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
> Cr-Commit-Position: refs/heads/master@{#416283}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Inline core HTML and SVG sources in the GN build. (patchset #1 id:1 of
https://codereview.chromium.org/2299143005/ )

Reason for revert:
This broke official builds, see
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm.

Original issue's description:
> Inline core SVG sources in the GN build.
>
> This adds targets in the corresponding directories where the various SVG files
> live. The SVG files are kept in separate targets in the "layout" and "style"
> subdirectories so that the current separation of SVG code is maintained.
>
> TBR=dpranke
>
> Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
> Cr-Commit-Position: refs/heads/master@{#416283}

TBR=dpranke@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/84dbf69d4c07a013d8f7e0278287a433bf5fd927
Cr-Commit-Position: refs/heads/master@{#416439}
==========

[commit-bot: I haz the power, 2016-09-03 03:38:59]

Patchset 1 (id:??) landed as
https://crrev.com/84dbf69d4c07a013d8f7e0278287a433bf5fd927
Cr-Commit-Position: refs/heads/master@{#416439}

[Dirk Pranke, 2016-09-06 01:05:55]

(lgtm)