Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2308933002: Plugin Power Saver Tiny: Add RAPPOR metric for new ALLOW exceptions. (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver Tiny: Add RAPPOR metric for new ALLOW exceptions. This catches new ALLOW exceptions added via the broken puzzle piece in the Omnibox and via the Website Settings dropdown. It doesn't catch ALLOW exceptions added manually via the chrome://settings Content Settings area. It's not obvious it's a good idea to convert the wildcard-patterns within that to RAPPOR domains. BUG=639503 Committed: https://crrev.com/34cf29bff5e0b6375e356a945a5ce12d477f294c Cr-Commit-Position: refs/heads/master@{#417198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
tommycli
groby, holte: PTAL, thanks!
4 years, 3 months ago (2016-09-03 00:36:05 UTC) #4
groby-ooo-7-16
lgtm
4 years, 3 months ago (2016-09-03 01:08:51 UTC) #5
Steven Holte
lgtm
4 years, 3 months ago (2016-09-06 20:28:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308933002/1
4 years, 3 months ago (2016-09-06 20:48:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/253801)
4 years, 3 months ago (2016-09-06 20:57:53 UTC) #10
tommycli
thestig: PTAL and cq if good enough? thanks!
4 years, 3 months ago (2016-09-08 02:15:11 UTC) #12
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-08 03:56:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308933002/1
4 years, 3 months ago (2016-09-08 03:56:22 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 05:46:44 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 05:49:01 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34cf29bff5e0b6375e356a945a5ce12d477f294c
Cr-Commit-Position: refs/heads/master@{#417198}

Powered by Google App Engine
This is Rietveld 408576698