Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2308913002: DevTools Uploader: migrate to GN (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman-cc_chromium.org, mnaganov-cc_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

DevTools Uploader: migrate to GN Since GYP were removed, the patch migrates devtools uploader to GN. BUG=643231, 643236 R=dgozman@chromium.org, dgozman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=0b0e9e4f5e4a079d16a0f1d83d31a8e4d2e1bd99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -27 lines) Patch
M gce/uploader_iteration.sh View 6 chunks +20 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
lushnikov
please, take a look!
4 years, 3 months ago (2016-09-02 23:18:44 UTC) #1
dgozman
lgtm
4 years, 3 months ago (2016-09-02 23:19:47 UTC) #2
lushnikov
4 years, 3 months ago (2016-09-03 00:09:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0b0e9e4f5e4a079d16a0f1d83d31a8e4d2e1bd99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698