Issue 2308903002: Small fixes for the lock screen md-settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2308903002: Small fixes for the lock screen md-settings page. (Closed)

Created:
4 years, 3 months ago by jdufault

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Small fixes for the lock screen md-settings page. BUG=642436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2277993002 Cr-Commit-Position: refs/heads/master@{#414608} (cherry picked from commit 09c7ebf5c8d47e2f1335f593e3abb47e013cd58d) Committed: https://chromium.googlesource.com/chromium/src/+/bc22493708f3d7437334ad553241ce3e05e61ef0

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -25 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/settings_strings.grdp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/settings/people_page/password_prompt_dialog.html	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/settings/people_page/password_prompt_dialog.js	View	2 chunks	+18 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/settings/people_page/setup_pin_dialog.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

jdufault

4 years, 3 months ago (2016-09-02 23:19:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bc22493708f3d7437334ad553241ce3e05e61ef0.