Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2308833002: Work around VS 2015 Update 3 optimizer internal compiler error (Closed)

Created:
4 years, 3 months ago by brucedawson
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Work around VS 2015 Update 3 optimizer internal compiler error VS 2015 Update 3 comes with a fancy new optimizer and this optimizer causes an internal compiler error on one skia function. This change works around the bug by disabling optimize-for-time for that function. Other options would be to add /d2SSAOptimizer- to the command-line for the file or project but that would *require* Update 3 which is not yet desirable. VS bug report is here: https://connect.microsoft.com/VisualStudio/feedback/details/3100520 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2308833002 Committed: https://skia.googlesource.com/skia/+/3c3e0d7bad86b805b08a81ab09d6f7ed25f47899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
brucedawson
4 years, 3 months ago (2016-09-02 21:30:11 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-09-06 12:47:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308833002/1
4 years, 3 months ago (2016-09-06 16:33:08 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:54:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3c3e0d7bad86b805b08a81ab09d6f7ed25f47899

Powered by Google App Engine
This is Rietveld 408576698