Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 230883003: Disable SiteInstanceTest.ProcessSharingByType in --site-per-process (Closed)

Created:
6 years, 8 months ago by nasko
Modified:
6 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Disable SiteInstanceTest.ProcessSharingByType in --site-per-process This test checks how we combine renderers across processes. --site-per-process does not allow combining renderers from different SiteInstances, so this test is not expected to work properly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/site_instance_impl_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nasko
Hey Charlie, Can you review this CL to disable a test that doesn't make sense ...
6 years, 8 months ago (2014-04-09 15:46:32 UTC) #1
Charlie Reis
LGTM, but can you change the subject and first line to include "in --site-per-process"? At ...
6 years, 8 months ago (2014-04-09 16:06:52 UTC) #2
nasko
Created crbug.com/361679.
6 years, 8 months ago (2014-04-09 18:00:34 UTC) #3
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 8 months ago (2014-04-09 18:00:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/230883003/1
6 years, 8 months ago (2014-04-09 18:00:53 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 20:29:21 UTC) #6
Message was sent while issue was closed.
Change committed as 262798

Powered by Google App Engine
This is Rietveld 408576698